Paths

Table of Contentst

Differential D8851

[web] Use chat mention candidates in markdown rules
ClosedPublic
Actions

Authored by • patryk on Aug 17 2023, 10:03 AM.

Tags

None

Referenced Files

	F3367391: D8851.diff
	Mon, Nov 25, 2:44 PM

	Unknown Object (File)
	Fri, Nov 15, 9:10 AM

	Unknown Object (File)
	Sun, Nov 10, 2:46 PM

	Unknown Object (File)
	Fri, Nov 8, 7:25 AM

	Unknown Object (File)
	Fri, Nov 8, 6:02 AM

	Unknown Object (File)
	Fri, Nov 8, 5:08 AM

	Unknown Object (File)
	Oct 27 2024, 2:49 PM

	Unknown Object (File)
	Oct 14 2024, 3:37 PM

Subscribers

Details

Reviewers

tomek
inka
rohan

Commits

rCOMM7df6fdf206fa: [web] Use chat mention candidates in markdown rules

Summary

This diff adds the chatMentionCandidates object to all functions that return textMessageRules in rules.react.js, and includes this object as a parameter in all occurrences of these functions.

Depends on D8871, D8834.

Test Plan

Before testing, please apply the entire web stack.

Check if mentions are rendered correctly (see D8852).
Check if mention content is not replaced to default text (@[[id:default text]]) when pending sidebar is created.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• patryk created this revision.Aug 17 2023, 10:03 AM

• patryk held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 17 2023, 10:03 AM

Harbormaster completed remote builds in B21849: Diff 30022.Aug 17 2023, 10:20 AM

Rebase

Harbormaster completed remote builds in B21910: Diff 30097.Aug 19 2023, 4:34 AM

• patryk edited the summary of this revision. (Show Details)Aug 19 2023, 3:35 PM

• patryk added a parent revision: D8871: [web][native] Refactor getDefaultTextMessageRules.

• patryk added a child revision: D8852: [web] Introduce markdown component for chat mentions.

• patryk edited the summary of this revision. (Show Details)Aug 20 2023, 6:29 AM

• patryk added a parent revision: D8834: [lib] Introduce chat mention match and parse utilities.

• patryk edited the summary of this revision. (Show Details)Aug 20 2023, 8:28 AM

• patryk edited the test plan for this revision. (Show Details)

• patryk added reviewers: tomek, inka, rohan.

• patryk edited the test plan for this revision. (Show Details)

• patryk mentioned this in D8853: [web] Add chat mention rule to text message rules.Aug 20 2023, 9:04 AM

• patryk published this revision for review.Aug 20 2023, 11:13 PM

inka accepted this revision.Aug 28 2023, 4:01 AM

This revision is now accepted and ready to land.Aug 28 2023, 4:01 AM

Change getDefaultTextMessageRules

Harbormaster completed remote builds in B22340: Diff 30692.Sep 1 2023, 3:32 AM

• patryk mentioned this in D8846: [native] Use chat mention candidates in markdown rules.Sep 1 2023, 3:39 AM

We probably should memoize the rules

Rebase and early return textMessageRules

Harbormaster completed remote builds in B22709: Diff 31245.Sep 19 2023, 2:12 AM

Closed by commit rCOMM7df6fdf206fa: [web] Use chat mention candidates in markdown rules (authored by • patryk). · Explain WhySep 28 2023, 1:59 AM

This revision was automatically updated to reflect the committed changes.

• patryk added a commit: rCOMM7df6fdf206fa: [web] Use chat mention candidates in markdown rules.

• patryk mentioned this in rCOMM70c89fb76aaf: [web] Add chat mention rule to text message rules.Sep 28 2023, 2:12 AM

Revision Contents
Changeset List

Path

Size

web/

chat/

chat-message-list.react.js

11 lines

message-preview.react.js

4 lines

components/

message-result.react.js

7 lines

markdown/

21 lines

modals/

threads/

sidebars/

sidebar.react.js

4 lines

subchannels/

subchannel.react.js

5 lines

selectors/

thread-selectors.js

14 lines

Diff 31493

web/chat/chat-message-list.react.js

Loading...

web/chat/message-preview.react.js

Loading...

web/components/message-result.react.js

Loading...

web/markdown/rules.react.js

Loading...

web/modals/threads/sidebars/sidebar.react.js

Loading...

web/modals/threads/subchannels/subchannel.react.js

Loading...

web/selectors/thread-selectors.js

Loading...