Paths

Table of Contentst

Differential D8875

[web] Make chat mentions clickable
ClosedPublic
Actions

Authored by • patryk on Aug 19 2023, 2:09 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Sep 3, 4:59 AM

	Unknown Object (File)
	Tue, Sep 3, 12:54 AM

	Unknown Object (File)
	Tue, Sep 3, 12:01 AM

	Unknown Object (File)
	Mon, Sep 2, 9:07 PM

	Unknown Object (File)
	Mon, Sep 2, 7:06 PM

	Unknown Object (File)
	Mon, Sep 2, 5:30 PM

	Unknown Object (File)
	Sun, Sep 1, 7:43 PM

	Unknown Object (File)
	Sat, Aug 31, 2:29 AM

View All 91 Files

Subscribers

Details

Reviewers

tomek
inka
rohan

Commits

rCOMM284efe67c34d: [web] Make chat mentions clickable

Summary

Solution for ENG-4561.

This diff uses useOnClickThread hook which redirects to chat when mention is clicked and uses it in markdown-chat-mention.react.js

Depends on D8852.

Test Plan

Before testing, please apply the entire web stack.

Test if mentions inside a spoiler are properly rendered and are clickable only when spoiler is opened:

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• patryk created this revision.Aug 19 2023, 2:09 PM

• patryk held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 19 2023, 2:09 PM

Harbormaster completed remote builds in B21919: Diff 30106.Aug 19 2023, 2:26 PM

• patryk edited the summary of this revision. (Show Details)Aug 19 2023, 3:36 PM

• patryk added a parent revision: D8852: [web] Introduce markdown component for chat mentions.

• patryk added a child revision: D8876: [web] Inherit colors on spoiler reveal animation.

• patryk added a child revision: D8877: [web] Fix spoiler animation for links.Aug 20 2023, 6:53 AM

• patryk edited the summary of this revision. (Show Details)Aug 20 2023, 8:43 AM

• patryk edited the test plan for this revision. (Show Details)

• patryk added reviewers: tomek, inka, rohan.

• patryk mentioned this in D8853: [web] Add chat mention rule to text message rules.Aug 20 2023, 9:04 AM

• patryk attached a referenced file: F698073: click-mention-spoiler-web.mp4. (Show Details)Aug 20 2023, 11:09 PM

• patryk published this revision for review.Aug 20 2023, 11:14 PM

inka accepted this revision.Aug 21 2023, 6:07 AM

This revision is now accepted and ready to land.Aug 21 2023, 6:07 AM

• patryk removed a child revision: D8876: [web] Inherit colors on spoiler reveal animation.Aug 21 2023, 6:11 AM

• patryk edited the summary of this revision. (Show Details)Aug 22 2023, 1:37 AM

Rebase

Harbormaster completed remote builds in B22268: Diff 30565.Aug 30 2023, 8:28 AM

tomek added inline comments.Sep 12 2023, 2:20 AM

web/markdown/markdown-chat-mention.react.js
11 ↗	(On Diff #30565)	We're introducing a new prop here without a corresponding change in the usage. Shouldn't that cause a Flow issue? Or is it the case that we start using this component later in the stack?

Rebase

web/markdown/markdown-chat-mention.react.js
11 ↗	(On Diff #30565)	We use this component later in the stack so maybe that's why Flow doesn't see an issue here.

Harbormaster completed remote builds in B22711: Diff 31247.Sep 19 2023, 2:17 AM

Rebase

Harbormaster completed remote builds in B22854: Diff 31437.Sep 27 2023, 7:05 AM

Closed by commit rCOMM284efe67c34d: [web] Make chat mentions clickable (authored by • patryk). · Explain WhySep 28 2023, 2:08 AM

This revision was automatically updated to reflect the committed changes.

• patryk added a commit: rCOMM284efe67c34d: [web] Make chat mentions clickable.

• patryk mentioned this in rCOMM70c89fb76aaf: [web] Add chat mention rule to text message rules.Sep 28 2023, 2:12 AM

Revision Contents
Changeset List

Path

Size

web/

markdown/

markdown-chat-mention.react.js

13 lines

Diff 31495

web/markdown/markdown-chat-mention.react.js

Loading...