Page MenuHomePhabricator

[web] Make chat mentions clickable
ClosedPublic

Authored by patryk on Aug 19 2023, 2:09 PM.
Tags
None
Referenced Files
F3137063: D8875.id30565.diff
Sat, Nov 2, 9:40 PM
Unknown Object (File)
Tue, Oct 15, 4:28 PM
Unknown Object (File)
Sat, Oct 12, 3:47 PM
Unknown Object (File)
Sep 27 2024, 6:57 PM
Unknown Object (File)
Sep 27 2024, 6:57 PM
Unknown Object (File)
Sep 27 2024, 6:57 PM
Unknown Object (File)
Sep 27 2024, 6:57 PM
Unknown Object (File)
Sep 27 2024, 6:57 PM
Subscribers

Details

Summary

Solution for ENG-4561.

This diff uses useOnClickThread hook which redirects to chat when mention is clicked and uses it in markdown-chat-mention.react.js

Depends on D8852.

Test Plan

Before testing, please apply the entire web stack.

Test if mentions inside a spoiler are properly rendered and are clickable only when spoiler is opened:

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

patryk held this revision as a draft.
patryk edited the test plan for this revision. (Show Details)
patryk added reviewers: tomek, inka, rohan.
This revision is now accepted and ready to land.Aug 21 2023, 6:07 AM
patryk edited the test plan for this revision. (Show Details)

Rebase

web/markdown/markdown-chat-mention.react.js
11 ↗(On Diff #30565)

We're introducing a new prop here without a corresponding change in the usage. Shouldn't that cause a Flow issue? Or is it the case that we start using this component later in the stack?

Rebase

web/markdown/markdown-chat-mention.react.js
11 ↗(On Diff #30565)

We use this component later in the stack so maybe that's why Flow doesn't see an issue here.

This revision was automatically updated to reflect the committed changes.