Page MenuHomePhabricator

[keyserver] Render raw chat mention in the notification text
AcceptedPublic

Authored by patryk on Fri, Sep 15, 10:15 AM.

Details

Reviewers
tomek
inka
rohan
Summary

Solution for ENG-4562.

This diff enables rendering raw chat mentions in notification text.

Depends on D9005.

Test Plan

Follow the test plan from D9007.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

patryk held this revision as a draft.

To render raw chat mentions in notification text, text-message-spec.js required changes to both messageTitle and notificationTexts. In the first case, markdownRules are passed as a parameter, and in previous diffs, I've added chatMentionCandidates to be used wherever we obtain markdownRules, so chat mentions will be rendered in the parser function. The second case is easier since we operate on a string; the string replace method is used to render chat mentions.

patryk published this revision for review.Tue, Sep 19, 4:16 AM

The diff title here should probably include the word "notification" somewhere :)

patryk retitled this revision from [keyserver] Render raw chat mention to [keyserver] Render raw chat mention in the notification text.Thu, Sep 21, 2:06 AM
This revision is now accepted and ready to land.Fri, Sep 22, 7:49 AM