Page MenuHomePhabricator

[keyserver] Render raw chat mention in the notification text
ClosedPublic

Authored by patryk on Sep 15 2023, 10:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 2, 4:10 PM
Unknown Object (File)
Wed, Oct 2, 12:08 PM
Unknown Object (File)
Fri, Sep 27, 5:55 PM
Unknown Object (File)
Fri, Sep 27, 5:55 PM
Unknown Object (File)
Fri, Sep 27, 5:55 PM
Unknown Object (File)
Fri, Sep 27, 5:49 PM
Unknown Object (File)
Wed, Sep 18, 6:55 PM
Unknown Object (File)
Mon, Sep 16, 12:48 PM
Subscribers

Details

Summary

Solution for ENG-4562.

This diff enables rendering raw chat mentions in notification text.

Depends on D9005.

Test Plan

Follow the test plan from D9007.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

patryk held this revision as a draft.

To render raw chat mentions in notification text, text-message-spec.js required changes to both messageTitle and notificationTexts. In the first case, markdownRules are passed as a parameter, and in previous diffs, I've added chatMentionCandidates to be used wherever we obtain markdownRules, so chat mentions will be rendered in the parser function. The second case is easier since we operate on a string; the string replace method is used to render chat mentions.

The diff title here should probably include the word "notification" somewhere :)

patryk retitled this revision from [keyserver] Render raw chat mention to [keyserver] Render raw chat mention in the notification text.Sep 21 2023, 2:06 AM
This revision is now accepted and ready to land.Sep 22 2023, 7:49 AM