Page MenuHomePhabricator

[lib] Encode chat name in raw chat mention
ClosedPublic

Authored by patryk on Aug 22 2023, 5:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 3:21 AM
Unknown Object (File)
Mon, Mar 17, 3:21 AM
Unknown Object (File)
Tue, Mar 11, 6:13 PM
Unknown Object (File)
Thu, Mar 6, 3:00 AM
Unknown Object (File)
Tue, Feb 25, 3:32 PM
Unknown Object (File)
Tue, Feb 25, 7:29 AM
Unknown Object (File)
Tue, Feb 25, 7:29 AM
Unknown Object (File)
Tue, Feb 25, 7:29 AM
Subscribers

Details

Summary

Solution for ENG-4554.

This diff introduces encodeChatMentionText function which replaces all ] char occurrences with \].

Depends on D8902.

Test Plan

Before testing, please apply entire native stack.

Test if chat names which include ] are encoded and rendered properly:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

patryk held this revision as a draft.
patryk edited the test plan for this revision. (Show Details)
patryk added reviewers: tomek, inka.
patryk edited the summary of this revision. (Show Details)
patryk edited the test plan for this revision. (Show Details)
patryk added a reviewer: rohan.
This revision is now accepted and ready to land.Aug 29 2023, 5:29 AM

Can you add some tests please?