Paths

Table of Contentst

-
lib/shared/
-
shared/
-
mention-utils.js

Differential D8908

[lib] Encode chat name in raw chat mention
ClosedPublic
Actions

Authored by • patryk on Aug 22 2023, 5:25 AM.

Tags

None

Referenced Files

	F5927226: D8908.id.diff
	Fri, Apr 18, 12:45 AM

	F5912438: D8908.id30214.diff
	Thu, Apr 17, 7:13 PM

	Unknown Object (File)
	Thu, Apr 17, 3:14 AM

	Unknown Object (File)
	Wed, Apr 9, 3:46 AM

	Unknown Object (File)
	Wed, Apr 9, 1:13 AM

	Unknown Object (File)
	Tue, Apr 8, 10:58 PM

	Unknown Object (File)
	Tue, Apr 8, 10:40 PM

	Unknown Object (File)
	Tue, Apr 8, 9:55 PM

Subscribers

Details

Reviewers

tomek
inka
rohan

Commits

rCOMMeb793d116fd1: [lib] Encode chat name in raw chat mention

Summary

Solution for ENG-4554.

This diff introduces encodeChatMentionText function which replaces all ] char occurrences with \].

Depends on D8902.

Test Plan

Before testing, please apply entire native stack.

Test if chat names which include ] are encoded and rendered properly:

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• patryk created this revision.Aug 22 2023, 5:25 AM

• patryk held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 22 2023, 5:25 AM

• patryk edited the summary of this revision. (Show Details)Aug 22 2023, 5:28 AM

• patryk edited the test plan for this revision. (Show Details)

• patryk added reviewers: tomek, inka.

• patryk edited the summary of this revision. (Show Details)

• patryk added a parent revision: D8902: [web][native] Use userStoreMentionSearchIndex.

• patryk added a child revision: D8909: [native] Replace chat name with raw chat mention.Aug 22 2023, 5:32 AM

Harbormaster completed remote builds in B22005: Diff 30214.Aug 22 2023, 5:43 AM

• patryk edited the summary of this revision. (Show Details)Aug 22 2023, 5:51 AM

• patryk edited the test plan for this revision. (Show Details)

• patryk added a reviewer: rohan.

• patryk edited the test plan for this revision. (Show Details)Aug 22 2023, 6:01 AM

• patryk attached a referenced file: F703249: testing weird chats.mp4. (Show Details)

• patryk published this revision for review.Aug 22 2023, 8:38 AM

Rebase

Harbormaster completed remote builds in B22067: Diff 30291.Aug 24 2023, 2:05 PM

• patryk added a child revision: D8943: [web] Refactor TypeaheadTooltip component.Aug 25 2023, 3:14 AM

inka accepted this revision.Aug 29 2023, 5:29 AM

This revision is now accepted and ready to land.Aug 29 2023, 5:29 AM

Can you add some tests please?

• patryk added a child revision: D9254: [lib] Add unit tests for mention utils.Sep 21 2023, 4:22 AM

Closed by commit rCOMMeb793d116fd1: [lib] Encode chat name in raw chat mention (authored by • patryk). · Explain WhySep 28 2023, 5:27 AM

This revision was automatically updated to reflect the committed changes.

• patryk added a commit: rCOMMeb793d116fd1: [lib] Encode chat name in raw chat mention.

Revision Contents
Changeset List

Path

Size

lib/

shared/

mention-utils.js

5 lines

Diff 31508

lib/shared/mention-utils.js

	Show All 37 Lines
	}			}

	const localUnshimTypes = new Set([			const localUnshimTypes = new Set([
	messageTypes.IMAGES,			messageTypes.IMAGES,
	messageTypes.UPDATE_RELATIONSHIP,			messageTypes.UPDATE_RELATIONSHIP,
	messageTypes.CREATE_SIDEBAR,			messageTypes.CREATE_SIDEBAR,
	messageTypes.SIDEBAR_SOURCE,			messageTypes.SIDEBAR_SOURCE,
	messageTypes.MULTIMEDIA,			messageTypes.MULTIMEDIA,
				messageTypes.REACTION,
	]);			]);
	function unshimMessageInfos(			function unshimMessageInfos(
	messageInfos: $ReadOnlyArray<RawMessageInfo>,			messageInfos: $ReadOnlyArray<RawMessageInfo>,
	): RawMessageInfo[] {			): RawMessageInfo[] {
	return messageInfos.map((messageInfo: RawMessageInfo) =>			return messageInfos.map((messageInfo: RawMessageInfo) =>
	unshimFunc(messageInfo, localUnshimTypes),			unshimFunc(messageInfo, localUnshimTypes),
	);			);
	}			}

	export { unshimMessageStore, unshimMessageInfos, unshimFunc };			export { unshimMessageStore, unshimMessageInfos, unshimFunc };