Paths

Table of Contentst

-
lib/shared/
-
shared/
1/1
mention-utils.js

Differential D8908

[lib] Encode chat name in raw chat mention
ClosedPublic
Actions

Authored by • patryk on Aug 22 2023, 5:25 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Mar 29, 9:38 PM

	Unknown Object (File)
	Mon, Mar 17, 3:21 AM

	Unknown Object (File)
	Mon, Mar 17, 3:21 AM

	Unknown Object (File)
	Tue, Mar 11, 6:13 PM

	Unknown Object (File)
	Thu, Mar 6, 3:00 AM

	Unknown Object (File)
	Feb 25 2025, 3:32 PM

	Unknown Object (File)
	Feb 25 2025, 7:29 AM

	Unknown Object (File)
	Feb 25 2025, 7:29 AM

Subscribers

Details

Reviewers

tomek
inka
rohan

Commits

rCOMMeb793d116fd1: [lib] Encode chat name in raw chat mention

Summary

Solution for ENG-4554.

This diff introduces encodeChatMentionText function which replaces all ] char occurrences with \].

Depends on D8902.

Test Plan

Before testing, please apply entire native stack.

Test if chat names which include ] are encoded and rendered properly:

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• patryk created this revision.Aug 22 2023, 5:25 AM

• patryk held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 22 2023, 5:25 AM

• patryk edited the summary of this revision. (Show Details)Aug 22 2023, 5:28 AM

• patryk edited the test plan for this revision. (Show Details)

• patryk added reviewers: tomek, inka.

• patryk edited the summary of this revision. (Show Details)

• patryk added a parent revision: D8902: [web][native] Use userStoreMentionSearchIndex.

• patryk added a child revision: D8909: [native] Replace chat name with raw chat mention.Aug 22 2023, 5:32 AM

Harbormaster completed remote builds in B22005: Diff 30214.Aug 22 2023, 5:43 AM

• patryk edited the summary of this revision. (Show Details)Aug 22 2023, 5:51 AM

• patryk edited the test plan for this revision. (Show Details)

• patryk added a reviewer: rohan.

• patryk edited the test plan for this revision. (Show Details)Aug 22 2023, 6:01 AM

• patryk attached a referenced file: F703249: testing weird chats.mp4. (Show Details)

• patryk published this revision for review.Aug 22 2023, 8:38 AM

Rebase

Harbormaster completed remote builds in B22067: Diff 30291.Aug 24 2023, 2:05 PM

• patryk added a child revision: D8943: [web] Refactor TypeaheadTooltip component.Aug 25 2023, 3:14 AM

inka accepted this revision.Aug 29 2023, 5:29 AM

This revision is now accepted and ready to land.Aug 29 2023, 5:29 AM

Can you add some tests please?

• patryk added a child revision: D9254: [lib] Add unit tests for mention utils.Sep 21 2023, 4:22 AM

Closed by commit rCOMMeb793d116fd1: [lib] Encode chat name in raw chat mention (authored by • patryk). · Explain WhySep 28 2023, 5:27 AM

This revision was automatically updated to reflect the committed changes.

• patryk added a commit: rCOMMeb793d116fd1: [lib] Encode chat name in raw chat mention.

Revision Contents
Changeset List

Path

Size

lib/

shared/

mention-utils.js

5 lines

Diff 31508

lib/shared/mention-utils.js

	Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
	const styles = StyleSheet.create({			const styles = StyleSheet.create({
	dummyMessage: {			dummyMessage: {
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 6,
	},			},
	message: {			message: {
	overflow: 'hidden',			overflow: 'hidden',
	paddingHorizontal: 12,			paddingHorizontal: 12,
	paddingVertical: 6,			paddingVertical: 8,
	},			},
	text: {			text: {
	fontFamily: 'Arial',			fontFamily: 'Arial',
	fontSize: 18,			fontSize: 14,
				benschacAuthorUnsubmitted Done Inline Actions I actually think this is a bit too small. But that's what's in the design. https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455 @ashoat - I think 16px looks better. benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
				lineHeight: 22,
	},			},
	});			});

	export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };			export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };