Paths

Table of Contentst

Differential D9056

[lib] Add unit tests for chat mention regex
ClosedPublic
Actions

Authored by • patryk on Aug 31 2023, 9:06 PM.

Tags

None

Referenced Files

	F32412067: D9056.1765346048.diff
	Tue, Dec 9, 5:54 AM

	F32300082: D9056.1765284919.diff
	Mon, Dec 8, 12:55 PM

Subscribers

Details

Reviewers

tomek
inka
rohan

Commits

rCOMM9d4b7ccde32f: [lib] Add unit tests for chat mention regex

Summary

This diff adds chat mention regex unit tests to markdown.test.js.

Depends on D8834.

Test Plan

Run yarn test in lib folder and check if all tests pass.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• patryk created this revision.Aug 31 2023, 9:06 PM

• patryk held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 31 2023, 9:06 PM

• patryk edited the summary of this revision. (Show Details)Aug 31 2023, 9:09 PM

• patryk edited the test plan for this revision. (Show Details)

• patryk added reviewers: tomek, inka, rohan.

• patryk added a parent revision: D8834: [lib] Introduce chat mention match and parse utilities.

• patryk edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B22328: Diff 30680.Aug 31 2023, 9:26 PM

• patryk added a child revision: D9057: [web] Add webMentionTypeaheadRegex tests.Aug 31 2023, 9:55 PM

• patryk published this revision for review.Sep 1 2023, 6:53 AM

Change test messages

Fix nits

Harbormaster completed remote builds in B22336: Diff 30688.Sep 1 2023, 7:16 AM

Harbormaster completed remote builds in B22337: Diff 30689.Sep 1 2023, 7:18 AM

Thanks for doing this!! Tests look great. I think outside of this file the pattern is to typically use it('should...), but I don't think it's a big deal

lib/shared/markdown.test.js
120 ↗	(On Diff #30689)
124 ↗	(On Diff #30689)

This revision is now accepted and ready to land.Sep 1 2023, 2:24 PM

Move match word

Harbormaster completed remote builds in B22705: Diff 31241.Sep 19 2023, 8:46 AM

Closed by commit rCOMM9d4b7ccde32f: [lib] Add unit tests for chat mention regex. · Explain WhySep 28 2023, 8:11 AM

This revision was automatically updated to reflect the committed changes.

• patryk added a commit: rCOMM9d4b7ccde32f: [lib] Add unit tests for chat mention regex.

Revision Contents
Changeset List

Path

Size

lib/

shared/

markdown.test.js

56 lines

Diff 31485

lib/shared/markdown.test.js

Loading...