Page MenuHomePhabricator

[web][native] Modify typeahead function and variable names to distinguish chat mention utilities
ClosedPublic

Authored by patryk on Aug 22 2023, 2:01 AM.
Tags
None
Referenced Files
F3374983: D8898.diff
Tue, Nov 26, 5:40 PM
Unknown Object (File)
Sat, Nov 23, 6:01 AM
Unknown Object (File)
Sat, Nov 23, 1:48 AM
Unknown Object (File)
Tue, Nov 19, 2:56 PM
Unknown Object (File)
Sat, Nov 9, 10:40 AM
Unknown Object (File)
Fri, Nov 1, 5:12 PM
Unknown Object (File)
Wed, Oct 30, 6:43 PM
Unknown Object (File)
Mon, Oct 28, 9:59 PM
Subscribers

Details

Summary

We need to distinguish user mentions from chat mentions so it's necessary to rename functions and variables which names are too generic. Also added word "mention" to typeahead tooltip utilities -> typeahead can be used not only for mentioning, so we should also indicate that.

Depends on D8897.

Test Plan

Check if there are no typos and if every affected part of code works properly.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

patryk held this revision as a draft.
patryk edited the test plan for this revision. (Show Details)
patryk added reviewers: tomek, inka.

Seems reasonable to me

This revision is now accepted and ready to land.Aug 24 2023, 7:15 AM