Paths

Table of Contentst

Differential D5019

[services] Backup - Use Blob client in c++ - Implement send log
ClosedPublic
Actions

Authored by • karol on Sep 1 2022, 11:10 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

• jon
tomek
• max

Commits

rCOMMd92ff5a3dcfd: [services] Backup - Use Blob client in c++ - Implement send log

Summary

Depends on D5018

Adding c++ implementation for using the blob client in the backup reactor for sending logs.

Test Plan

backup builds

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Sep 1 2022, 11:10 AM

Herald added a reviewer: • jon. · View Herald TranscriptSep 1 2022, 11:10 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

• karol edited the summary of this revision. (Show Details)Sep 1 2022, 11:26 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, • max.

• karol added a parent revision: D5018: [services] Backup - Use Blob client in c++ - Implement add attachment.

• karol added a child revision: D5020: [services] Backup - Use Blob client in c++ - Implement pull backup.

Harbormaster completed remote builds in B11776: Diff 16179.Sep 1 2022, 11:33 AM

• karol requested review of this revision.Sep 1 2022, 11:33 AM

• karol planned changes to this revision.Sep 2 2022, 12:47 PM

rebase

Harbormaster failed remote builds in B11842: Diff 16247!Sep 2 2022, 12:53 PM

Why do we call put_client_blocking_read_cxx a couple of times?

services/backup/src/Reactors/server/SendLogReactor.cpp
120–150	Is this approach correct according to gRPC recommendation? This might take long and is called from a reactor - but we probably should return as soon as possible from these.

This revision now requires changes to proceed.Sep 5 2022, 2:14 PM

In D5019#146919, @tomek wrote:

Why do we call put_client_blocking_read_cxx a couple of times?

Explained in https://phab.comm.dev/D5017#147269

services/backup/src/Reactors/server/SendLogReactor.cpp
120–150	This is a part of this task, I intentionally left it to fix later https://linear.app/comm/issue/ENG-1724/solve-the-problem-with-blocked-reactors-in-grpc

tomek accepted this revision.Sep 7 2022, 12:30 PM

This revision is now accepted and ready to land.Sep 7 2022, 12:30 PM

rebase

This revision was landed with ongoing or failed builds.Sep 8 2022, 11:10 AM

Closed by commit rCOMMd92ff5a3dcfd: [services] Backup - Use Blob client in c++ - Implement send log. · Explain Why

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMMd92ff5a3dcfd: [services] Backup - Use Blob client in c++ - Implement send log.

Harbormaster completed remote builds in B11996: Diff 16451.Sep 8 2022, 11:23 AM

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

Reactors/

server/

SendLogReactor.h

2 lines

SendLogReactor.cpp

64 lines

Diff 16247

services/backup/src/Reactors/server/SendLogReactor.h

Loading...

services/backup/src/Reactors/server/SendLogReactor.cpp

Loading...