Page MenuHomePhabricator
Differential D5018

[services] Backup - Use Blob client in c++ - Implement add attachment
ClosedPublic
Actions

Authored by • karol on Sep 1 2022, 4:10 AM.
Tags
None
Referenced Files
F5113865: D5018.id16477.diff
Wed, Apr 2, 6:18 AM
F5113864: D5018.id16178.diff
Wed, Apr 2, 6:18 AM
F5109727: D5018.diff
Tue, Apr 1, 8:33 PM
F5109063: D5018.id16450.diff
Tue, Apr 1, 4:35 PM
F5109062: D5018.id16396.diff
Tue, Apr 1, 4:35 PM
F5109061: D5018.id16355.diff
Tue, Apr 1, 4:35 PM
F5109060: D5018.id16246.diff
Tue, Apr 1, 4:35 PM
F5107152: D5018.diff
Tue, Apr 1, 10:32 AM
View All Files
Subscribers
• abosh
ashoat
atul
tomek

Details

Reviewers
• jon
tomek
• max
Commits
rCOMM0b822963c7ec: [services] Backup - Use Blob client in c++ - Implement add attachment
Summary

Depends on D5017

Adding c++ implementation for using the blob client in the backup reactor for adding attachments.

Test Plan

backup builds

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.Sep 1 2022, 4:10 AM
Herald added a reviewer: • jon. · View Herald TranscriptSep 1 2022, 4:10 AM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript
• karol edited the summary of this revision. (Show Details)Sep 1 2022, 4:26 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, • max.
• karol added a parent revision: D5017: [services] Backup - Use Blob client in c++ - Implement create new backup.
• karol added a child revision: D5019: [services] Backup - Use Blob client in c++ - Implement send log.
Harbormaster completed remote builds in B11775: Diff 16178.Sep 1 2022, 4:29 AM
• karol requested review of this revision.Sep 1 2022, 4:29 AM
• karol planned changes to this revision.Sep 2 2022, 5:47 AM
• karol updated this revision to Diff 16246.Sep 2 2022, 5:48 AM

rebase

Harbormaster failed remote builds in B11841: Diff 16246!Sep 2 2022, 5:52 AM
tomek requested changes to this revision.Sep 5 2022, 5:56 AM
tomek added inline comments.
services/backup/src/Reactors/server/AddAttachmentsUtility.cpp
78–80 ↗(On Diff #16246)

Doesn't seem like parentheses pair here.

backup builds

Are you sure?

This revision now requires changes to proceed.Sep 5 2022, 5:56 AM
• karol updated this revision to Diff 16355.Sep 6 2022, 3:22 AM

fix

services/backup/src/Reactors/server/AddAttachmentsUtility.cpp
78–80 ↗(On Diff #16246)

ok thx not sure how this happened, will fix

Harbormaster completed remote builds in B11912: Diff 16355.Sep 6 2022, 3:32 AM
• karol planned changes to this revision.Sep 7 2022, 2:32 AM

remove the comments

• karol updated this revision to Diff 16396.Sep 7 2022, 2:34 AM

remove comments

tomek accepted this revision.Sep 7 2022, 5:24 AM
tomek added inline comments.
services/backup/src/Reactors/server/AddAttachmentsUtility.cpp
81 ↗(On Diff #16396)

Is there a downside of calling one write after another without the read between them?

This revision is now accepted and ready to land.Sep 7 2022, 5:24 AM
• karol added inline comments.Sep 8 2022, 3:48 AM
services/backup/src/Reactors/server/AddAttachmentsUtility.cpp
81 ↗(On Diff #16396)

I think I explained this in another task. Anyway, the thing is, this is how grpc works, it yields a response even if it is empty. Our response queue is limited to 1 (after that, it will hang), so we should always read using the bidi stream, no matter if we use the response or not. We can, of course, add additional logic that would automatically discard responses.

• karol updated this revision to Diff 16450.Sep 8 2022, 4:01 AM

rebase

Harbormaster failed remote builds in B11995: Diff 16450!Sep 8 2022, 4:09 AM
This revision was landed with ongoing or failed builds.Sep 8 2022, 4:10 AM
Closed by commit rCOMM0b822963c7ec: [services] Backup - Use Blob client in c++ - Implement add attachment (authored by • karol). · Explain Why
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM0b822963c7ec: [services] Backup - Use Blob client in c++ - Implement add attachment.

Revision Contents
Changeset List

PathSize
services/
backup/
src/
Reactors/
server/
38 lines

Diff 16355

View Options

services/backup/src/Reactors/server/AddAttachmentsUtility.cpp

// @flow // @flow
import { HeaderBackButton as BaseHeaderBackButton } from '@react-navigation/elements'; import { HeaderBackButton as BaseHeaderBackButton } from '@react-navigation/elements';
import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import { Text } from 'react-native'; import { Alert, Text } from 'react-native';
import { TouchableOpacity } from 'react-native-gesture-handler'; import { TouchableOpacity } from 'react-native-gesture-handler';
import type { NavigationRoute } from '../navigation/route-names';
import { useColors } from '../themes/colors.js'; import { useColors } from '../themes/colors.js';
type Props = React.ElementConfig<typeof BaseHeaderBackButton>; type ChangeRolesHeaderLeftButtonProps = {
function ChangeRolesHeaderLeftButton(props: Props): React.Node { +route: NavigationRoute<'ChangeRolesScreen'>,
...React.ElementConfig<typeof BaseHeaderBackButton>,
};
function ChangeRolesHeaderLeftButton(
props: ChangeRolesHeaderLeftButtonProps,
): React.Node {
const { memberInfo, role: selectedRole } = props.route.params;
const { role: memberRole } = memberInfo;
const onCancel = React.useCallback(() => {
const { onPress } = props;
invariant(onPress, 'onPress must be defined');
if (selectedRole === memberRole) {
onPress();
return;
}
Alert.alert(
'Unsaved Changes',
'You have unsaved changes, are you sure you want to cancel? You will lose all your progress',
[
{ text: 'Cancel', onPress },
{ text: 'Stay', style: 'cancel' },
],
{ cancelable: true },
);
}, [memberRole, props, selectedRole]);
rohanAuthorUnsubmitted
Done
Inline Actions

I think the wording here may be a bit confusing. In my experience, 'cancel' typically means close the alert, and there's another option like 'confirm' or something that will mean you're ok with discarding changes.

Here it seems like 'cancel' means we're ok with discarding changes. Not sure if it's just me though (cc @ted)

rohan: I think the wording here may be a bit confusing. In my experience, 'cancel' typically means…
ashoatUnsubmitted
Not Done
Inline Actions

What do we do in the current edit-message workflow? Heads-up I generally handle copy, not @ted

ashoat: What do we do in the current edit-message workflow? Heads-up I generally handle copy, not @ted
rohanAuthorUnsubmitted
Done
Inline Actions

Ah my bad. It looks like in message editing: Continue editing closes the alert and continues editing while Discard edit closes the alert and exits editing

rohan: Ah my bad. It looks like in message editing: `Continue editing` closes the alert and continues…
ashoatUnsubmitted
Not Done
Inline Actions
  1. I agree we shouldn't use the term Cancel here... how about Leave?
  2. I don't think we need { cancelable: true }... we can just default to Stay if the user dismisses the Alert
  3. Can we try to match copy for title / description with the edit-message workflow?
ashoat: 1. I agree we shouldn't use the term `Cancel` here... how about `Leave`? 2. I don't think we…
rohanAuthorUnsubmitted
Done
Inline Actions

Yeah that makes sense, I'll update the diff

rohan: Yeah that makes sense, I'll update the diff
const { panelForegroundSecondaryLabel } = useColors(); const { panelForegroundSecondaryLabel } = useColors();
const labelStyle = React.useMemo( const labelStyle = React.useMemo(
() => ({ () => ({
color: panelForegroundSecondaryLabel, color: panelForegroundSecondaryLabel,
marginLeft: 10, marginLeft: 10,
}), }),
[panelForegroundSecondaryLabel], [panelForegroundSecondaryLabel],
); );
return ( return (
<TouchableOpacity onPress={props.onPress}> <TouchableOpacity onPress={onCancel}>
<Text style={labelStyle}>Cancel</Text> <Text style={labelStyle}>Cancel</Text>
</TouchableOpacity> </TouchableOpacity>
); );
} }
export default ChangeRolesHeaderLeftButton; export default ChangeRolesHeaderLeftButton;