Depends on D5029
I just moved the function report_error to the mutual space tools following the DRY rule.
Details
Details
cd services yarn run-integration-tests backup
Works as before
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| services/backup/blob_client/src/tools.rs | ||
|---|---|---|
| 5 ↗ | (On Diff #16239) | Why pass a global variable? It's always going to be available. Taking a step back, we shouldn't be using global variables; if we just want to see if something is in a valid state, we should attach the state to the respective resource (e.g. client). |
| 9–12 ↗ | (On Diff #16239) | what's the value that labels provide? Couldn't the message just contain it. If we were using log statements, one could also pass a target argument. We would just need to initiate the logger alongside the runtime. |
| services/backup/blob_client/src/tools.rs | ||
|---|---|---|
| 5 ↗ | (On Diff #16239) | |
| 9–12 ↗ | (On Diff #16239) | I think we can do this in this task https://linear.app/comm/issue/ENG-1717/use-tracing-utilities-instead-of-println I'm going to add a note. |
| services/backup/blob_client/src/tools.rs | ||
|---|---|---|
| 5 ↗ | (On Diff #16239) | I think this is kind of side stepping the issue. I think the current complexity could be reduced by just emitting the errors and representing the check_errors() as checking to see if a Mutex<bool> is true. Even better would be marking the individual clients as healthy and have some logic to get them back to healthy, but that's more work, and should be done later as another task. |