Paths

Table of Contentst

Differential D5031

[services] Rust Integration - Backup - Make check_error shared
ClosedPublic
Actions

Authored by • karol on Sep 1 2022, 11:54 PM.

Tags

None

Referenced Files

	F3280037: D5031.id16224.diff
	Sat, Nov 16, 9:00 AM

	Unknown Object (File)
	Sun, Nov 10, 6:57 AM

	Unknown Object (File)
	Wed, Oct 30, 5:44 PM

	Unknown Object (File)
	Wed, Oct 30, 2:38 AM

	Unknown Object (File)
	Sun, Oct 27, 8:12 PM

	Unknown Object (File)
	Sun, Oct 27, 8:12 PM

	Unknown Object (File)
	Sun, Oct 27, 8:12 PM

	Unknown Object (File)
	Sun, Oct 27, 8:12 PM

Subscribers

Details

Reviewers

• jon
• max
varun
tomek

Commits

rCOMM48b066b17f71: [services] Rust Integration - Backup - Make check_error shared

Summary

Depends on D5030

I just moved the function check_error to the mutual space tools following the DRY rule.

Test Plan

cd services
yarn run-integration-tests backup

Works as before

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Sep 1 2022, 11:54 PM

Herald added a reviewer: • jon. · View Herald TranscriptSep 1 2022, 11:54 PM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

rebase

• karol edited the summary of this revision. (Show Details)Sep 2 2022, 12:05 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: • max, varun, tomek.

• karol edited the summary of this revision. (Show Details)

• karol added a parent revision: D5030: [services] Rust Integration - Backup - Make report_error shared.

Harbormaster completed remote builds in B11819: Diff 16224.Sep 2 2022, 12:07 AM

Harbormaster completed remote builds in B11822: Diff 16227.Sep 2 2022, 12:11 AM

• karol requested review of this revision.Sep 2 2022, 12:11 AM

• karol added a child revision: D5034: [services] Rust Integration - Backup - Rust - Add converting functions.Sep 2 2022, 3:55 AM

• karol planned changes to this revision.Sep 2 2022, 7:20 AM

rebase

Harbormaster failed remote builds in B11845: Diff 16250!Sep 2 2022, 7:24 AM

tomek accepted this revision.Sep 5 2022, 7:42 AM

tomek added inline comments.

services/backup/blob_client/src/get_client.rs
118 ↗	(On Diff #16250)	Is there a way to avoid `ERROR_MESSAGES` in every call? E.g. we can create a function that calls `check_error(&ERROR_MESSAGES)` or modify `ERROR_MESSAGES` to be a struct that has `check` method. We're considering changing the approach of handling errors, so maybe this comment shouldn't be addressed here, but might become useful when designing the new approach.

This revision is now accepted and ready to land.Sep 5 2022, 7:42 AM

• karol mentioned this in D5013: [services] Backup - Blob Get Client - Add base structure.Sep 6 2022, 1:43 AM

update

Harbormaster completed remote builds in B11924: Diff 16370.Sep 6 2022, 7:27 AM

rebase

This revision was landed with ongoing or failed builds.Sep 8 2022, 4:10 AM

Closed by commit rCOMM48b066b17f71: [services] Rust Integration - Backup - Make check_error shared (authored by • karol). · Explain Why

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM48b066b17f71: [services] Rust Integration - Backup - Make check_error shared.

Harbormaster completed remote builds in B12004: Diff 16459.Sep 8 2022, 4:34 AM

Revision Contents
Changeset List

Path

Size

services/

backup/

blob_client/

src/

22 lines

26 lines

10 lines

Diff 16459

services/backup/blob_client/src/get_client.rs

Loading...

services/backup/blob_client/src/put_client.rs

Loading...

services/backup/blob_client/src/tools.rs

Loading...