Page MenuHomePhabricator

[services] Rust Integration - Backup - Stop rethrowing in send log reactor
ClosedPublic

Authored by karol on Sep 1 2022, 11:53 PM.
Tags
None
Referenced Files
F2834790: D5027.diff
Sat, Sep 28, 12:07 PM
Unknown Object (File)
Thu, Sep 26, 8:16 PM
Unknown Object (File)
Thu, Sep 26, 8:16 PM
Unknown Object (File)
Thu, Sep 26, 8:16 PM
Unknown Object (File)
Thu, Sep 26, 8:15 PM
Unknown Object (File)
Thu, Sep 26, 8:09 PM
Unknown Object (File)
Thu, Sep 5, 1:07 AM
Unknown Object (File)
Aug 28 2024, 10:55 PM

Details

Summary

Depends on D5026

Linear task: https://linear.app/comm/issue/ENG-1727/catch-stdexception-in-base-reactors

We started using rust, and we use functions that return Result. That Result is then converted into a std::exception in c++ when it returns Err. All over the place in the reactors we handle std::runtime_errors but we should go higher in the hierarchy and catch std::exceptions.

Here, I removed rethrowing in send log reactor as it is caught in the base reactors (earlier in this stack).

Test Plan
cd services
yarn run-integration-tests backup

Works as before (of course, you have to start backup and blob services first).

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Sep 5 2022, 7:30 AM
This revision was landed with ongoing or failed builds.Sep 8 2022, 4:10 AM
This revision was automatically updated to reflect the committed changes.