Depends on D5036
In order to be able to handle multiple connections at the same time, we have to store a collection of clients in the rust state instead of having just one.
Here, I'm adding the collection to the get blob client.
Details
Details
The backup service will not build successfully because of invalid calls from the c++ but I decided to divide the code so the diffs are not too big. This is fixed in the next diff in the stack - D5038
This will work:
cd services/backup/blob_client cargo check
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| services/backup/blob_client/src/get_client.rs | ||
|---|---|---|
| 146–157 ↗ | (On Diff #16236) | Ok, so let's do that. If we're locking here that might affect performance significantly. |
| services/backup/blob_client/src/get_client.rs | ||
|---|---|---|
| 146–157 ↗ | (On Diff #16236) | Do we have a task for this investigation? |
| services/backup/blob_client/src/get_client.rs | ||
|---|---|---|
| 146–157 ↗ | (On Diff #16236) | |
Comment Actions
The code looks ok, but I'm confused why this diff introduces things that are replaced later. Especially, raw pointers and unsafe functions. Is this diff going to be updated?
Also the CI fails for this diff.
| services/backup/blob_client/src/get_client.rs | ||
|---|---|---|
| 36 ↗ | (On Diff #16686) | We're not mutating, so &str is more appropriate |
Comment Actions
Also the CI fails for this diff.
The CI fails because we don't use the changes from rust in c++ yet, we do that in D5038 but I didn't want to make this diff too big. On the other hand, the diff philosophy is that every single diff should not break the master branch... To speed things up, I'll just land them together, sorry, maybe I made a mistake and should've done that differently.
| services/backup/blob_client/src/get_client.rs | ||
|---|---|---|
| 36 ↗ | (On Diff #16686) | |