Page MenuHomePhabricator
Differential D7346

[native] Copy the edited message content to ChatInputBar when entering edit mode
ClosedPublic
Actions

Authored by • kuba on Apr 7 2023, 7:19 AM.
Tags
None
Referenced Files
F3187791: D7346.id24959.diff
Fri, Nov 8, 5:05 PM
F3187777: D7346.id24963.diff
Fri, Nov 8, 5:05 PM
F3187769: D7346.id24795.diff
Fri, Nov 8, 5:05 PM
F3187765: D7346.id25665.diff
Fri, Nov 8, 5:05 PM
F3187719: D7346.id.diff
Fri, Nov 8, 5:04 PM
F3187616: D7346.diff
Fri, Nov 8, 4:42 PM
F3185555: D7346.id24963.diff
Fri, Nov 8, 12:59 PM
F3185552: D7346.id25665.diff
Fri, Nov 8, 12:59 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
michal
inka
ginsu
Commits
rCOMMcdc4c8f7b606: [native] Copy the edited message content to ChatInputBar when entering edit mode
Summary

We want to set the content of the edited message in the ChatInputBar when entering edit mode. We need a callback, to always have the latest state.

Test Plan

Run the app on iOS. Checked if when entering the edit mode the content of the message is copied to the InputBar.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• kuba created this revision.Apr 7 2023, 7:19 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 7 2023, 7:19 AM
• kuba added a parent revision: D7345: [native] Change 'addReply' function to 'editInputMessage'.Apr 7 2023, 7:19 AM
• kuba added inline comments.
native/input/input-state-container.react.js
1213

I had to add the callback, to have the updated state when editing the ChatInputBar. It is necessary, especially for later diffs, where I store the message draft when entering edit mode.

• kuba added a child revision: D7347: [native] Preserve the draft for ChatInputBar after leaving edit mode.Apr 7 2023, 7:22 AM
Harbormaster completed remote builds in B18095: Diff 24795.Apr 7 2023, 7:42 AM
• kuba requested review of this revision.Apr 7 2023, 7:42 AM
inka added inline comments.Apr 11 2023, 4:06 AM
native/chat/text-message-tooltip-modal.react.js
68–73

Shouldn't this be inside React.useCallback?
Although I suppose if you wrap onPressEdit then there is no need, because they have the same dependencies.

• kuba updated this revision to Diff 24959.Apr 11 2023, 5:09 AM
• kuba marked an inline comment as done.
This comment was removed by • kuba.
Harbormaster completed remote builds in B18223: Diff 24959.Apr 11 2023, 5:25 AM
• kuba updated this revision to Diff 24963.Apr 11 2023, 5:31 AM

Moved useCallback change to the earlier diff

• kuba added inline comments.Apr 11 2023, 5:32 AM
native/chat/text-message-tooltip-modal.react.js
68–73

I wrapped the whole onPressEdit with React.useCallback in earlier diff.

Harbormaster completed remote builds in B18227: Diff 24963.Apr 11 2023, 5:48 AM
inka accepted this revision.Apr 12 2023, 5:16 AM
This revision is now accepted and ready to land.Apr 12 2023, 5:16 AM
Closed by commit rCOMMcdc4c8f7b606: [native] Copy the edited message content to ChatInputBar when entering edit mode (authored by kosmydel <kukubaczek@gmail.com>). · Explain WhyApr 25 2023, 6:44 AM
This revision was automatically updated to reflect the committed changes.
kosmydel <kukubaczek@gmail.com> added a commit: rCOMMcdc4c8f7b606: [native] Copy the edited message content to ChatInputBar when entering edit mode.

Revision Contents
Changeset List

Diff 24795

View Options

native/chat/text-message-tooltip-modal.react.js

Loading...
View Options

native/input/input-state-container.react.js

Loading...
View Options

native/input/input-state.js

Loading...