[native] Added edit button to the Tooltip
ClosedPublic
Actions

Authored by • kuba on Apr 7 2023, 6:55 AM.

Details

Reviewers

michal
inka
ginsu

Commits

rCOMMafba840f9fb3: [native] Added edit button to the Tooltip

Summary

Added Edit button to the tooltip, which selects a message for editing. It is shown only for messages in which the author is the viewer. The edit button is hidden behind the EDIT_BUTTON_DISPLAY feature flag.

Test Plan

Checked if the edit button displays correctly in the tooltip.
Checked if the buttons are correctly handled and if there are many of them.
Checked if the state is correctly changed in dev tools.
Checked if the button is only shown for users from staff.js.

Screenshot 2023-04-07 at 16.02.41.png (472×732 px, 96 KB)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• kuba created this revision.Apr 7 2023, 6:55 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 7 2023, 6:55 AM

• kuba added a parent revision: D7342: [native] Add EditState to the InputState.Apr 7 2023, 6:56 AM

• kuba added a child revision: D7344: [native] Displaying edit mode.

• kuba edited the summary of this revision. (Show Details)Apr 7 2023, 7:03 AM

• kuba edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B18083: Diff 24783.Apr 7 2023, 7:12 AM

• kuba requested review of this revision.Apr 7 2023, 7:12 AM

ashoat mentioned this in D7342: [native] Add EditState to the InputState.Apr 7 2023, 7:24 AM

inka added inline comments.Apr 11 2023, 4:07 AM

native/chat/text-message-tooltip-modal.react.js
57–58 ↗	(On Diff #24783)	can't this be `const { messageInfo } = route.params.item;`? I don't think you use `item` anywhere afterwards
60–66 ↗	(On Diff #24783)	Shouldn't this be inside React.useCallback?