Page MenuHomePhabricator
Differential D7414

[native] Change EditState to store messageInfo instead of only id
ClosedPublic
Actions

Authored by • kuba on Apr 13 2023, 4:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 21, 4:19 PM
Unknown Object (File)
Mon, Apr 21, 6:43 AM
Unknown Object (File)
Mon, Apr 21, 12:02 AM
Unknown Object (File)
Sun, Apr 20, 2:40 AM
Unknown Object (File)
Thu, Apr 3, 3:59 PM
Unknown Object (File)
Tue, Apr 1, 8:31 AM
Unknown Object (File)
Mar 17 2025, 5:47 PM
Unknown Object (File)
Mar 17 2025, 2:45 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
michal
inka
ginsu
tomek
Commits
rCOMMe5cd32b03032: [native] Change EditState to store messageInfo instead of only id
Summary

Updated to provide messageInfo for next diff.
We need not only the id of the message but also its content. Now, we store the full messageInfo of the edited message.

Test Plan

Checked if the app still works as expected after the changes.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• kuba created this revision.Apr 13 2023, 4:01 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 13 2023, 4:01 AM
• kuba added a child revision: D7344: [native] Displaying edit mode.Apr 13 2023, 4:01 AM
• kuba added a parent revision: D7343: [native] Added edit button to the Tooltip.Apr 13 2023, 4:09 AM
• kuba mentioned this in D7344: [native] Displaying edit mode.Apr 13 2023, 4:15 AM
Harbormaster completed remote builds in B18311: Diff 25089.Apr 13 2023, 4:19 AM
• kuba requested review of this revision.Apr 13 2023, 4:19 AM
• kuba added a reviewer: tomek.Apr 13 2023, 4:23 AM
• kuba edited the summary of this revision. (Show Details)
tomek accepted this revision.Apr 14 2023, 3:23 AM
tomek added inline comments.
native/input/input-state.js
61

Do we use this callback?

This revision is now accepted and ready to land.Apr 14 2023, 3:23 AM
• kuba added inline comments.Apr 14 2023, 6:25 AM
native/input/input-state.js
61

Yes, i.g. in this diff: https://phab.comm.dev/D7347 in the file native/chat/chat-input-bar.react.js line 798.

Closed by commit rCOMMe5cd32b03032: [native] Change EditState to store messageInfo instead of only id (authored by kosmydel <kukubaczek@gmail.com>). · Explain WhyApr 25 2023, 6:44 AM
This revision was automatically updated to reflect the committed changes.
kosmydel <kukubaczek@gmail.com> added a commit: rCOMMe5cd32b03032: [native] Change EditState to store messageInfo instead of only id.

Revision Contents
Changeset List

Diff 25089

View Options

native/chat/text-message-tooltip-modal.react.js

Show All 20 Lines
import { import {
useServerCall, useServerCall,
useDispatchActionPromise, useDispatchActionPromise,
} from 'lib/utils/action-utils'; } from 'lib/utils/action-utils';
import MenuItem from '../components/menu-item.react'; import MenuItem from '../components/menu-item.react';
import Menu from '../components/menu.react'; import Menu from '../components/menu.react';
import SidebarListModal from '../modals/chat/sidebar-list-modal.react'; import SidebarListModal from '../modals/chat/sidebar-list-modal.react';
import SidebarPromoteModal from '../modals/chat/sidebar-promote-modal.react';
import { useModalContext } from '../modals/modal-provider.react'; import { useModalContext } from '../modals/modal-provider.react';
import ConfirmLeaveThreadModal from '../modals/threads/confirm-leave-thread-modal.react'; import ConfirmLeaveThreadModal from '../modals/threads/confirm-leave-thread-modal.react';
import ThreadMembersModal from '../modals/threads/members/members-modal.react'; import ThreadMembersModal from '../modals/threads/members/members-modal.react';
import SubchannelsModal from '../modals/threads/subchannels/subchannels-modal.react'; import SubchannelsModal from '../modals/threads/subchannels/subchannels-modal.react';
import ThreadSettingsModal from '../modals/threads/thread-settings-modal.react'; import ThreadSettingsModal from '../modals/threads/thread-settings-modal.react';
import { useSelector } from '../redux/redux-utils'; import { useSelector } from '../redux/redux-utils';
import SWMansionIcon from '../SWMansionIcon.react'; import SWMansionIcon from '../SWMansionIcon.react';
import css from './thread-menu.css'; import css from './thread-menu.css';
▲ Show 20 Lines • Show All 154 Lines • ▼ Show 20 Lines return (
text="Leave Thread" text="Leave Thread"
icon="logout" icon="logout"
dangerous dangerous
onClick={onClickLeaveThread} onClick={onClickLeaveThread}
/> />
); );
}, [onClickLeaveThread, threadInfo]); }, [onClickLeaveThread, threadInfo]);
const onClickPromoteSidebarToThread = React.useCallback(
() =>
pushModal(
<SidebarPromoteModal
threadInfo={threadInfo}
onClose={popModal}
onConfirm={onPromoteSidebar}
/>,
),
[pushModal, threadInfo, popModal, onPromoteSidebar],
);
const promoteSidebar = React.useMemo(() => { const promoteSidebar = React.useMemo(() => {
return ( return (
<MenuItem <MenuItem
key="promote" key="promote"
text="Promote Thread" text="Promote Thread"
icon="message-square-lines" icon="message-square-lines"
onClick={onPromoteSidebar} onClick={onClickPromoteSidebarToThread}
/> />
); );
}, [onPromoteSidebar]); }, [onClickPromoteSidebarToThread]);
const menuItems = React.useMemo(() => { const menuItems = React.useMemo(() => {
const notificationsItem = ( const notificationsItem = (
<MenuItem key="notifications" text="Notifications" icon="bell" /> <MenuItem key="notifications" text="Notifications" icon="bell" />
); );
const separator = <hr key="separator" className={css.separator} />; const separator = <hr key="separator" className={css.separator} />;
// TODO: Enable menu items when the modals are implemented // TODO: Enable menu items when the modals are implemented
Show All 33 Lines
View Options

native/input/input-state-container.react.js

Show All 20 Lines
import { import {
useServerCall, useServerCall,
useDispatchActionPromise, useDispatchActionPromise,
} from 'lib/utils/action-utils'; } from 'lib/utils/action-utils';
import MenuItem from '../components/menu-item.react'; import MenuItem from '../components/menu-item.react';
import Menu from '../components/menu.react'; import Menu from '../components/menu.react';
import SidebarListModal from '../modals/chat/sidebar-list-modal.react'; import SidebarListModal from '../modals/chat/sidebar-list-modal.react';
import SidebarPromoteModal from '../modals/chat/sidebar-promote-modal.react';
import { useModalContext } from '../modals/modal-provider.react'; import { useModalContext } from '../modals/modal-provider.react';
import ConfirmLeaveThreadModal from '../modals/threads/confirm-leave-thread-modal.react'; import ConfirmLeaveThreadModal from '../modals/threads/confirm-leave-thread-modal.react';
import ThreadMembersModal from '../modals/threads/members/members-modal.react'; import ThreadMembersModal from '../modals/threads/members/members-modal.react';
import SubchannelsModal from '../modals/threads/subchannels/subchannels-modal.react'; import SubchannelsModal from '../modals/threads/subchannels/subchannels-modal.react';
import ThreadSettingsModal from '../modals/threads/thread-settings-modal.react'; import ThreadSettingsModal from '../modals/threads/thread-settings-modal.react';
import { useSelector } from '../redux/redux-utils'; import { useSelector } from '../redux/redux-utils';
import SWMansionIcon from '../SWMansionIcon.react'; import SWMansionIcon from '../SWMansionIcon.react';
import css from './thread-menu.css'; import css from './thread-menu.css';
▲ Show 20 Lines • Show All 154 Lines • ▼ Show 20 Lines return (
text="Leave Thread" text="Leave Thread"
icon="logout" icon="logout"
dangerous dangerous
onClick={onClickLeaveThread} onClick={onClickLeaveThread}
/> />
); );
}, [onClickLeaveThread, threadInfo]); }, [onClickLeaveThread, threadInfo]);
const onClickPromoteSidebarToThread = React.useCallback(
() =>
pushModal(
<SidebarPromoteModal
threadInfo={threadInfo}
onClose={popModal}
onConfirm={onPromoteSidebar}
/>,
),
[pushModal, threadInfo, popModal, onPromoteSidebar],
);
const promoteSidebar = React.useMemo(() => { const promoteSidebar = React.useMemo(() => {
return ( return (
<MenuItem <MenuItem
key="promote" key="promote"
text="Promote Thread" text="Promote Thread"
icon="message-square-lines" icon="message-square-lines"
onClick={onPromoteSidebar} onClick={onClickPromoteSidebarToThread}
/> />
); );
}, [onPromoteSidebar]); }, [onClickPromoteSidebarToThread]);
const menuItems = React.useMemo(() => { const menuItems = React.useMemo(() => {
const notificationsItem = ( const notificationsItem = (
<MenuItem key="notifications" text="Notifications" icon="bell" /> <MenuItem key="notifications" text="Notifications" icon="bell" />
); );
const separator = <hr key="separator" className={css.separator} />; const separator = <hr key="separator" className={css.separator} />;
// TODO: Enable menu items when the modals are implemented // TODO: Enable menu items when the modals are implemented
Show All 33 Lines
View Options

native/input/input-state.js

Show All 20 Lines
import { import {
useServerCall, useServerCall,
useDispatchActionPromise, useDispatchActionPromise,
} from 'lib/utils/action-utils'; } from 'lib/utils/action-utils';
import MenuItem from '../components/menu-item.react'; import MenuItem from '../components/menu-item.react';
import Menu from '../components/menu.react'; import Menu from '../components/menu.react';
import SidebarListModal from '../modals/chat/sidebar-list-modal.react'; import SidebarListModal from '../modals/chat/sidebar-list-modal.react';
import SidebarPromoteModal from '../modals/chat/sidebar-promote-modal.react';
import { useModalContext } from '../modals/modal-provider.react'; import { useModalContext } from '../modals/modal-provider.react';
import ConfirmLeaveThreadModal from '../modals/threads/confirm-leave-thread-modal.react'; import ConfirmLeaveThreadModal from '../modals/threads/confirm-leave-thread-modal.react';
import ThreadMembersModal from '../modals/threads/members/members-modal.react'; import ThreadMembersModal from '../modals/threads/members/members-modal.react';
import SubchannelsModal from '../modals/threads/subchannels/subchannels-modal.react'; import SubchannelsModal from '../modals/threads/subchannels/subchannels-modal.react';
import ThreadSettingsModal from '../modals/threads/thread-settings-modal.react'; import ThreadSettingsModal from '../modals/threads/thread-settings-modal.react';
import { useSelector } from '../redux/redux-utils'; import { useSelector } from '../redux/redux-utils';
import SWMansionIcon from '../SWMansionIcon.react'; import SWMansionIcon from '../SWMansionIcon.react';
import css from './thread-menu.css'; import css from './thread-menu.css';
▲ Show 20 Lines • Show All 154 Lines • ▼ Show 20 Lines return (
text="Leave Thread" text="Leave Thread"
icon="logout" icon="logout"
dangerous dangerous
onClick={onClickLeaveThread} onClick={onClickLeaveThread}
/> />
); );
}, [onClickLeaveThread, threadInfo]); }, [onClickLeaveThread, threadInfo]);
const onClickPromoteSidebarToThread = React.useCallback(
() =>
pushModal(
<SidebarPromoteModal
threadInfo={threadInfo}
onClose={popModal}
onConfirm={onPromoteSidebar}
/>,
),
[pushModal, threadInfo, popModal, onPromoteSidebar],
);
const promoteSidebar = React.useMemo(() => { const promoteSidebar = React.useMemo(() => {
return ( return (
<MenuItem <MenuItem
key="promote" key="promote"
text="Promote Thread" text="Promote Thread"
icon="message-square-lines" icon="message-square-lines"
onClick={onPromoteSidebar} onClick={onClickPromoteSidebarToThread}
/> />
); );
}, [onPromoteSidebar]); }, [onClickPromoteSidebarToThread]);
const menuItems = React.useMemo(() => { const menuItems = React.useMemo(() => {
const notificationsItem = ( const notificationsItem = (
<MenuItem key="notifications" text="Notifications" icon="bell" /> <MenuItem key="notifications" text="Notifications" icon="bell" />
); );
const separator = <hr key="separator" className={css.separator} />; const separator = <hr key="separator" className={css.separator} />;
// TODO: Enable menu items when the modals are implemented // TODO: Enable menu items when the modals are implemented
Show All 33 Lines