Paths

Table of Contentst

Differential D7651

[keyserver, lib] Add message search endpoint
ClosedPublic
Actions

Authored by inka on Apr 27 2023, 6:15 AM.

Tags

None

Referenced Files

	F3180761: D7651.id25816.diff
	Fri, Nov 8, 5:16 AM

	Unknown Object (File)
	Sat, Nov 2, 2:31 PM

	Unknown Object (File)
	Fri, Nov 1, 5:33 AM

	Unknown Object (File)
	Mon, Oct 28, 1:44 AM

	Unknown Object (File)
	Thu, Oct 24, 8:35 AM

	Unknown Object (File)
	Tue, Oct 22, 5:33 PM

	Unknown Object (File)
	Mon, Oct 21, 2:07 AM

	Unknown Object (File)
	Sep 28 2024, 6:30 AM

Subscribers

Details

Reviewers

kamil
bartek
• kuba
ashoat

Commits

rCOMM7e7050dee8ae: [keyserver, lib] Add message search endpoint

Summary

issue: https://linear.app/comm/issue/ENG-3170/create-a-keyserver-endpoint-for-the-message-search-within-specific
This endpoint allows searching messages. For now we can only search in one thread. It will have to be changed a bit in the future to be able to search in many threads, but we don't yet know how we will want that to work.

Test Plan

Tested with the next diff

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Apr 27 2023, 6:15 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 27 2023, 6:15 AM

inka added a parent revision: D7585: [keyserver] Add function for fetching messages matching search query.Apr 27 2023, 6:15 AM

inka added a child revision: D7652: [lib] Allow calling message search from client.Apr 27 2023, 6:23 AM

Harbormaster completed remote builds in B18847: Diff 25816.Apr 27 2023, 6:33 AM

inka requested review of this revision.Apr 27 2023, 6:33 AM

ashoat accepted this revision.Apr 27 2023, 12:43 PM

ashoat added inline comments.

lib/types/message-types.js
697	Personally I don't think we really need these aliases, we could just use `SearchMessagesResponse` throughout. I don't feel strongly though

This revision is now accepted and ready to land.Apr 27 2023, 12:43 PM

Remove SearchMessagesResult, rebase

Harbormaster completed remote builds in B19013: Diff 26033.May 3 2023, 1:19 AM

Add endReached to response from message search endpoint

Harbormaster completed remote builds in B19103: Diff 26153.May 8 2023, 2:14 AM

Fix - related messages were being counted to check if the end was reached.

Harbormaster completed remote builds in B19107: Diff 26160.May 8 2023, 2:55 AM

ashoat mentioned this in D7585: [keyserver] Add function for fetching messages matching search query.May 8 2023, 6:41 AM

Rebase

Harbormaster completed remote builds in B19193: Diff 26275.May 9 2023, 3:36 AM

Rebase

Harbormaster completed remote builds in B19356: Diff 26487.May 16 2023, 1:55 AM

Closed by commit rCOMM7e7050dee8ae: [keyserver, lib] Add message search endpoint (authored by • InkaSokolowska). · Explain WhyMay 24 2023, 2:12 AM

This revision was automatically updated to reflect the committed changes.

• InkaSokolowska added a commit: rCOMM7e7050dee8ae: [keyserver, lib] Add message search endpoint.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

5 lines

responders/

message-responders.js

25 lines

lib/

types/

1 line

message-types.js

12 lines

Diff 25816

keyserver/src/endpoints.js

Loading...

keyserver/src/responders/message-responders.js

Loading...

lib/types/endpoints.js

Loading...

lib/types/message-types.js

Loading...