Page MenuHomePhabricator
Differential D8677

[web] clean up InlineEngagement component
ClosedPublic
Actions

Authored by ginsu on Jul 31 2023, 7:15 AM.
Tags
None
Referenced Files
F3368551: D8677.diff
Mon, Nov 25, 8:12 PM
Unknown Object (File)
Sat, Nov 23, 11:37 PM
Unknown Object (File)
Sat, Nov 23, 11:37 PM
Unknown Object (File)
Sat, Nov 23, 11:37 PM
Unknown Object (File)
Sat, Nov 23, 11:37 PM
Unknown Object (File)
Sat, Nov 23, 4:28 AM
Unknown Object (File)
Fri, Nov 22, 7:17 PM
Unknown Object (File)
Sun, Nov 3, 7:40 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM9c1905dc7549: [web] clean up InlineEngagement component
Summary

Small cleanup diff to better organize and make the InlineEngagement component easier to read/go through. The two changes to note are

  1. Renamed threadInfo to sidebarThreadInfo: This is what we did in D8496
  2. Renamed messageLabel to editedLabel: In native we call the edited label editedLabel, so I updated this name to keep everything consistent.
Test Plan

Confirmed that InlineEngagment still looked and behaved the same.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Jul 31 2023, 7:15 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 31 2023, 7:15 AM
ginsu published this revision for review.Jul 31 2023, 7:18 AM
ginsu edited the summary of this revision. (Show Details)
ginsu added reviewers: atul, kamil.
ginsu added a child revision: D8678: [web] split the inline engagement pill into two.Jul 31 2023, 7:24 AM
Harbormaster completed remote builds in B21371: Diff 29275.Jul 31 2023, 8:45 AM
atul accepted this revision.Jul 31 2023, 11:49 AM

Didn't review too carefully, looks like a straightforward rename diff.

This revision is now accepted and ready to land.Jul 31 2023, 11:49 AM
ginsu updated this revision to Diff 29366.Jul 31 2023, 1:27 PM

rebase before landing

This revision was landed with ongoing or failed builds.Jul 31 2023, 1:28 PM
Closed by commit rCOMM9c1905dc7549: [web] clean up InlineEngagement component (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM9c1905dc7549: [web] clean up InlineEngagement component.
Harbormaster completed remote builds in B21439: Diff 29366.Jul 31 2023, 11:41 PM

Revision Contents
Changeset List

Diff 29367

View Options

web/chat/composed-message.react.js

Loading...
View Options

web/chat/inline-engagement.css

Loading...
View Options

web/chat/inline-engagement.react.js

Loading...
View Options

web/chat/robotext-message.react.js

Loading...