Page MenuHomePhabricator

[web] add space between inline engagement container and edges of chat window
ClosedPublic

Authored by ginsu on Aug 2 2023, 11:46 AM.
Tags
None
Referenced Files
F3151872: D8707.id30374.diff
Tue, Nov 5, 3:37 AM
F3151866: D8707.id30362.diff
Tue, Nov 5, 3:33 AM
Unknown Object (File)
Fri, Nov 1, 1:24 PM
Unknown Object (File)
Mon, Oct 28, 7:43 AM
Unknown Object (File)
Mon, Oct 14, 3:27 AM
Unknown Object (File)
Sep 28 2024, 9:32 AM
Unknown Object (File)
Sep 28 2024, 9:32 AM
Unknown Object (File)
Sep 28 2024, 9:32 AM
Subscribers

Details

Summary

Currently our inline engagement containers that are left/right aligned are flush against the chat window (see screenshot below) and are different sizes from each other. This was okay for our old inline engagement; however, our new inline engagement will separate out reaction into it's own pill and the pills will wrap if there is an overflow. Since there will be wrapping in this container we should add some space so the elements inside don't touch the edges.

This diff adds space between the inline engagement container and the edges of the chat window, and in doing so also makes sure that all of the inline engagement containers have the exact same size to each other.

Screenshot 2023-08-02 at 2.31.38 PM.png (2×3 px, 1 MB)

Depends on D8684

Test Plan

Please see the screenshots below. Also confirmed that all the inline engagement containers have the same width even when the browser window changes width/size

Screenshot 2023-08-02 at 2.36.26 PM.png (2×3 px, 1 MB)

Screenshot 2023-08-02 at 2.36.20 PM.png (2×3 px, 1 MB)

Screenshot 2023-08-02 at 2.36.15 PM.png (2×3 px, 1 MB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 2 2023, 12:13 PM
Harbormaster failed remote builds in B21494: Diff 29487!
ginsu requested review of this revision.Aug 2 2023, 12:23 PM
This revision is now accepted and ready to land.Aug 3 2023, 9:28 PM