Page MenuHomePhabricator
Differential D8819

[web] introduce ReactionPill component
ClosedPublic
Actions

Authored by ginsu on Aug 15 2023, 10:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 2:30 PM
Unknown Object (File)
Sat, Dec 14, 2:34 AM
Unknown Object (File)
Fri, Dec 6, 1:43 PM
Unknown Object (File)
Thu, Dec 5, 5:05 AM
Unknown Object (File)
Nov 25 2024, 9:15 PM
Unknown Object (File)
Nov 22 2024, 3:48 PM
Unknown Object (File)
Nov 22 2024, 11:02 AM
Unknown Object (File)
Nov 22 2024, 10:27 AM
View All 96 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM7661ac1baf29: [web] introduce ReactionPill component
Summary

As I was working on implementing the reaction tooltip I was having to put a ton of reaction specific code into InlineEngagement. This was getting messy really quick so I created and introduced this ReactionPill component to keep the logic organized

Depends on D8810

Test Plan

flow and no regressions with the ReactionPill (The pill looks the same and I can still react/unreact by clicking on the pill)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Aug 15 2023, 10:19 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 15 2023, 10:19 AM
ginsu edited the summary of this revision. (Show Details)Aug 15 2023, 10:20 AM
ginsu added reviewers: atul, kamil.
ginsu added a parent revision: D8810: [web] show which reactions the viewer has already selected in the inline engagement.
ginsu updated this revision to Diff 29916.Aug 15 2023, 10:22 AM

remove accidental reaction-tooltip.react.js file

Harbormaster failed remote builds in B21762: Diff 29915!Aug 15 2023, 10:36 AM
Harbormaster completed remote builds in B21763: Diff 29916.Aug 15 2023, 10:41 AM
ginsu requested review of this revision.Aug 15 2023, 10:41 AM
ginsu added a child revision: D8823: [web] introduce ReactionTooltip component.Aug 15 2023, 4:48 PM
ginsu removed a child revision: D8823: [web] introduce ReactionTooltip component.Aug 15 2023, 11:33 PM
ginsu added a child revision: D8826: [web] rename getMessageActionTooltipStyle to getTooltipStyle.Aug 15 2023, 11:38 PM
kamil accepted this revision.Aug 16 2023, 2:28 AM
kamil added inline comments.
web/chat/reaction-pill.react.js
16–18

I think we should avoid passing large objects to child component when possible

This revision is now accepted and ready to land.Aug 16 2023, 2:28 AM
ginsu updated this revision to Diff 30382.Aug 27 2023, 8:50 PM

address feedback and rebase before landing

Harbormaster completed remote builds in B22136: Diff 30382.Aug 27 2023, 9:08 PM
Closed by commit rCOMM7661ac1baf29: [web] introduce ReactionPill component (authored by ginsu). · Explain WhyAug 27 2023, 10:04 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM7661ac1baf29: [web] introduce ReactionPill component.

Revision Contents
Changeset List

Diff 29916

View Options

web/chat/inline-engagement.css

Loading...
View Options

web/chat/inline-engagement.react.js

Loading...
View Options

web/chat/reaction-pill.css

Loading...
View Options

web/chat/reaction-pill.react.js

Loading...