Page MenuHomePhabricator

[web] introduce ReactionPill component
ClosedPublic

Authored by ginsu on Aug 15 2023, 10:19 AM.
Tags
None
Referenced Files
F2113265: D8819.id30397.diff
Wed, Jun 26, 3:14 AM
F2109358: D8819.id30397.diff
Tue, Jun 25, 4:06 PM
Unknown Object (File)
Fri, Jun 21, 11:49 PM
Unknown Object (File)
Fri, Jun 21, 4:21 PM
Unknown Object (File)
Fri, Jun 21, 8:19 AM
Unknown Object (File)
Wed, Jun 19, 12:29 PM
Unknown Object (File)
Tue, Jun 18, 8:17 PM
Unknown Object (File)
Fri, Jun 14, 9:36 PM
Subscribers

Details

Summary

As I was working on implementing the reaction tooltip I was having to put a ton of reaction specific code into InlineEngagement. This was getting messy really quick so I created and introduced this ReactionPill component to keep the logic organized

Depends on D8810

Test Plan

flow and no regressions with the ReactionPill (The pill looks the same and I can still react/unreact by clicking on the pill)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

remove accidental reaction-tooltip.react.js file

kamil added inline comments.
web/chat/reaction-pill.react.js
16–18 ↗(On Diff #29916)

I think we should avoid passing large objects to child component when possible

This revision is now accepted and ready to land.Aug 16 2023, 2:28 AM

address feedback and rebase before landing

This revision was automatically updated to reflect the committed changes.