[web] convert createTooltip to getTooltipPositionStyle
ClosedPublic
Actions

Authored by ginsu on Aug 15 2023, 11:42 PM.

Details

Reviewers

atul
rohan
kamil

Commits

rCOMMb4efda7028af: [web] convert createTooltip to getTooltipPositionStyle

Summary

In an effort to make the tooltip code more component agnostic, I refactored this function to only get and return the tooltip position style since this logic can be reused for every single different type of tooltip we introduce in the future (which we are about to do shortly), and factored out any message tooltip specific code and put it back into the useMessageTooltip hook

Depends on D8826

Test Plan

flow and confirmed that the message tooltip on web still behaves and works as expected

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Aug 15 2023, 11:42 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 15 2023, 11:43 PM

ginsu edited the summary of this revision. (Show Details)Aug 15 2023, 11:44 PM

ginsu added reviewers: atul, kamil.

ginsu added a parent revision: D8826: [web] rename getMessageActionTooltipStyle to getTooltipStyle.

ginsu edited the summary of this revision. (Show Details)

ginsu edited the summary of this revision. (Show Details)Aug 15 2023, 11:46 PM

ginsu edited the summary of this revision. (Show Details)

ginsu added a child revision: D8828: [web] move getTooltipPositionStyle into tooltip-utils.Aug 15 2023, 11:54 PM

Harbormaster completed remote builds in B21780: Diff 29934.Aug 16 2023, 12:00 AM

ginsu requested review of this revision.Aug 16 2023, 12:00 AM

Adding Rohan as reviewer

not really familiar with tooltip code

Looks good, would prefer if someone more familiar with the tooltip could confirm though since my changes were mainly just fixing a cyclic dependency issue

This revision is now accepted and ready to land.Aug 17 2023, 10:41 AM