Page MenuHomePhabricator
Differential D8711

[web] move reaction message action type logic into useSendReaction
ClosedPublic
Actions

Authored by ginsu on Aug 2 2023, 12:30 PM.
Tags
None
Referenced Files
F3348655: D8711.id30366.diff
Fri, Nov 22, 3:42 PM
F3347135: D8711.diff
Fri, Nov 22, 11:12 AM
Unknown Object (File)
Mon, Oct 28, 7:45 AM
Unknown Object (File)
Mon, Oct 28, 7:45 AM
Unknown Object (File)
Mon, Oct 28, 7:45 AM
Unknown Object (File)
Mon, Oct 28, 7:45 AM
Unknown Object (File)
Mon, Oct 28, 7:43 AM
Unknown Object (File)
Sep 28 2024, 8:52 AM
View All 89 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM1ad3e712612d: [web] move reaction message action type logic into useSendReaction
Summary

This diff brings in the logic which determines if we are reacting or unreacting to a message into the useSendReaction hook. I don't know why we didn't do this initially, but this diff resolves this and will make it so we don't need to copy/paste this logic when we call useSendReaction with the InlineEngagement

Depends on D8710

Test Plan

flow and confirmed that I can still react and unreact to messages

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Aug 2 2023, 12:30 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 2 2023, 12:30 PM
ginsu published this revision for review.Aug 2 2023, 12:31 PM
ginsu edited the summary of this revision. (Show Details)
ginsu added reviewers: atul, kamil.
ginsu added a parent revision: D8710: [web] make reactions prop for InlineEngagement requried.
Harbormaster failed remote builds in B21499: Diff 29493!Aug 2 2023, 2:42 PM
atul accepted this revision.Aug 3 2023, 9:36 PM
This revision is now accepted and ready to land.Aug 3 2023, 9:36 PM
Harbormaster completed remote builds in B21499: Diff 29493.Aug 3 2023, 9:41 PM
ginsu added a child revision: D8807: [lib/native/web] factor out localID logic into helper hook.Aug 14 2023, 9:39 AM
ginsu updated this revision to Diff 30366.Aug 27 2023, 7:51 PM

rebase before landing

Harbormaster completed remote builds in B22132: Diff 30366.Aug 27 2023, 8:08 PM
Closed by commit rCOMM1ad3e712612d: [web] move reaction message action type logic into useSendReaction (authored by ginsu). · Explain WhyAug 27 2023, 8:34 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM1ad3e712612d: [web] move reaction message action type logic into useSendReaction.

Revision Contents
Changeset List

PathSize
web/
chat/
17 lines
12 lines

Diff 30378

View Options

web/chat/message-tooltip.react.js

Loading...
View Options

web/chat/reaction-message-utils.js

Loading...