Paths

Table of Contentst

Differential D9200

[Tunnelbroker] add authentication tests
ClosedPublic
Actions

Authored by kamil on Sep 14 2023, 3:10 AM.

Tags

None

Referenced Files

	F3364676: D9200.id31127.diff
	Mon, Nov 25, 4:35 AM

	Unknown Object (File)
	Fri, Nov 22, 10:34 AM

	Unknown Object (File)
	Fri, Nov 22, 4:59 AM

	Unknown Object (File)
	Mon, Oct 28, 11:02 PM

	Unknown Object (File)
	Sun, Oct 27, 3:42 PM

	Unknown Object (File)
	Oct 14 2024, 1:26 AM

	Unknown Object (File)
	Sep 27 2024, 10:26 PM

	Unknown Object (File)
	Sep 27 2024, 10:26 PM

Subscribers

Details

Reviewers

bartek
michal
varun
• jon

Commits

rCOMMb3c4cff3502d: [Tunnelbroker] add authentication tests

Summary

I implemented those to make sure D8918 works in both cases, so publishing, maybe will be helpful.

Depends on D8918

Test Plan

Start identity service, tunnelbroker

cd services/commtest
cargo test --test identity_tunnelbroker_tests

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Sep 14 2023, 3:10 AM

kamil held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptSep 14 2023, 3:10 AM

Herald added subscribers: tomek, ashoat. · View Herald Transcript

kamil published this revision for review.Sep 14 2023, 3:20 AM

Harbormaster completed remote builds in B22626: Diff 31123.Sep 14 2023, 3:28 AM

bartek accepted this revision.Sep 14 2023, 3:39 AM

bartek added inline comments.

services/commtest/tests/identity_tunnelbroker_tests.rs
45 ↗	(On Diff #31123)	Nit: Are these `unwrap`s hiding some meaningful error? It's usually a good practice to use `expect("error message")` instead. This way if this fails, we at least know what exactly failed. Otherwise, error messages are rather vague.

This revision is now accepted and ready to land.Sep 14 2023, 3:39 AM

michal accepted this revision.Sep 14 2023, 3:41 AM

unwrap -> expect

Harbormaster completed remote builds in B22630: Diff 31127.Sep 14 2023, 4:16 AM

Closed by commit rCOMMb3c4cff3502d: [Tunnelbroker] add authentication tests (authored by kamil). · Explain WhySep 14 2023, 5:23 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMb3c4cff3502d: [Tunnelbroker] add authentication tests.

Revision Contents
Changeset List

Path

Size

services/

commtest/

tests/

identity_tunnelbroker_tests.rs

66 lines

Diff 31130

services/commtest/tests/identity_tunnelbroker_tests.rs

Loading...