Page MenuHomePhabricator
Differential D8874

[native] Memorize ChatContextProvider
ClosedPublic
Actions

Authored by • patryk on Aug 19 2023, 10:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 13, 11:12 AM
Unknown Object (File)
Fri, Jan 31, 8:40 PM
Unknown Object (File)
Fri, Jan 31, 8:40 PM
Unknown Object (File)
Fri, Jan 31, 8:40 PM
Unknown Object (File)
Fri, Jan 31, 8:32 PM
Unknown Object (File)
Fri, Jan 24, 11:11 AM
Unknown Object (File)
Dec 16 2024, 10:33 PM
Unknown Object (File)
Nov 30 2024, 12:13 AM
View All 86 Files
Subscribers
ashoat
tomek

Details

Reviewers
tomek
inka
Commits
rCOMMb2d2f732a29b: [native] Memorize ChatContextProvider
Summary

D8847 changes ChatContextProvider position in root.react.js. We can also wrap this provider in React.memo.

Depends on D8847.

Test Plan

Run native app and check if everything works properly.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• patryk created this revision.Aug 19 2023, 10:22 AM
• patryk held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 19 2023, 10:22 AM
Harbormaster completed remote builds in B21918: Diff 30105.Aug 19 2023, 10:40 AM
• patryk edited the summary of this revision. (Show Details)Aug 19 2023, 11:03 AM
• patryk edited the test plan for this revision. (Show Details)
• patryk added reviewers: tomek, inka.
• patryk edited the summary of this revision. (Show Details)Aug 19 2023, 3:29 PM
• patryk added a parent revision: D8847: [native] Change ChatContextProvider position.
• patryk added a child revision: D8849: [native] Add chat mention rule to text message rules.
• patryk mentioned this in D8847: [native] Change ChatContextProvider position.Aug 20 2023, 7:56 AM
• patryk edited the summary of this revision. (Show Details)Aug 20 2023, 1:54 PM
• patryk published this revision for review.Aug 20 2023, 11:13 PM
tomek accepted this revision.Sep 12 2023, 1:56 AM
This revision is now accepted and ready to land.Sep 12 2023, 1:56 AM
Closed by commit rCOMMb2d2f732a29b: [native] Memorize ChatContextProvider (authored by • patryk). · Explain WhySep 28 2023, 1:40 AM
This revision was automatically updated to reflect the committed changes.
• patryk added a commit: rCOMMb2d2f732a29b: [native] Memorize ChatContextProvider.

Revision Contents
Changeset List

PathSize
native/
chat/
5 lines

Diff 31491

View Options

native/chat/chat-context-provider.react.js

Loading...