[identity] Implement attribute conversions for Device row
ClosedPublic
Actions

Authored by bartek on Dec 7 2023, 12:05 AM.

Details

Reviewers

michal
varun

Commits

rCOMM44607df0dff5: [identity] Implement attribute conversions for Device row

Summary

Added From traits to convert DeviceRow from/into AttributeValues. Copied this pattern from other services - it's very handy

Depends on D10213

Test Plan

Tested later in the stack. TODO: Add unit tests

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Dec 7 2023, 12:05 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 7 2023, 12:05 AM

bartek added a child revision: D10215: [identity] Implemet attribute conversions for DeviceList row.Dec 7 2023, 12:05 AM

Harbormaster completed remote builds in B24842: Diff 34364.Dec 7 2023, 12:32 AM

bartek published this revision for review.Dec 7 2023, 1:05 AM

varun accepted this revision.Dec 7 2023, 9:14 PM

This revision is now accepted and ready to land.Dec 7 2023, 9:14 PM

Use nested types for prekeys / identity keys

Harbormaster failed remote builds in B24961: Diff 34499!Dec 12 2023, 12:05 AM

This revision was landed with ongoing or failed builds.Jan 5 2024, 1:22 AM

Closed by commit rCOMM44607df0dff5: [identity] Implement attribute conversions for Device row (authored by bartek). · Explain Why

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM44607df0dff5: [identity] Implement attribute conversions for Device row.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

database/

device_list.rs

148 lines

Diff 34364

View Options

services/identity/src/database/device_list.rs

[identity] Implement attribute conversions for Device rowClosedPublicActions