Paths

Table of Contentst

Differential D10268

[lib] Replace `LegacyRawThreadInfos` with `RawThreadInfos` where simple in `shared/updates`
ClosedPublic
Actions

Authored by atul on Dec 8 2023, 11:49 AM.

Tags

None

Referenced Files

	F3159385: D10268.id34445.diff
	Tue, Nov 5, 10:38 PM

	F3159383: D10268.id34601.diff
	Tue, Nov 5, 10:38 PM

	Unknown Object (File)
	Tue, Oct 15, 9:51 PM

	Unknown Object (File)
	Tue, Oct 15, 9:51 PM

	Unknown Object (File)
	Tue, Oct 15, 9:51 PM

	Unknown Object (File)
	Tue, Oct 15, 9:51 PM

	Unknown Object (File)
	Tue, Oct 15, 9:51 PM

	Unknown Object (File)
	Sep 4 2024, 4:11 PM

View All 60 Files

Subscribers

None

Details

Reviewers

ashoat
ginsu
rohan
tomek

Commits

rCOMM379b729b9287: [lib] Replace `LegacyRawThreadInfos` with `RawThreadInfos` where simple in…

Summary

Continuation of D10243.

NOTE: CI is expected to fail. I got to a point in my local environment where all flow issues were resolved, but based on earlier fedback in the stack I'm breaking them down so things are easier to review.. even if that means that intermediate steps fail.

Depends on D10243

Test Plan

CI/flow/etc.

Diff Detail

Repository

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Dec 8 2023, 11:49 AM

atul published this revision for review.Dec 8 2023, 11:49 AM

ginsu accepted this revision.Dec 8 2023, 11:51 AM

This revision is now accepted and ready to land.Dec 8 2023, 11:51 AM

atul added a child revision: D10270: [lib] Add ridiculous branching to `delete-account-spec` to appease `flow`.Dec 8 2023, 11:58 AM

Harbormaster failed remote builds in B24911: Diff 34445!Dec 8 2023, 12:01 PM

final rebase pass

Harbormaster failed remote builds in B25041: Diff 34601!Dec 13 2023, 2:52 PM

This revision was landed with ongoing or failed builds.Dec 14 2023, 12:48 PM

Closed by commit rCOMM379b729b9287: [lib] Replace `LegacyRawThreadInfos` with `RawThreadInfos` where simple in… (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM379b729b9287: [lib] Replace `LegacyRawThreadInfos` with `RawThreadInfos` where simple in….

Revision Contents
Changeset List

Path

Size

lib/

shared/

updates/

delete-thread-spec.js

4 lines

join-thread-spec.js

4 lines

6 lines

update-thread-spec.js

4 lines

Diff 34445

lib/shared/updates/delete-thread-spec.js

Loading...

lib/shared/updates/join-thread-spec.js

Loading...

lib/shared/updates/update-spec.js

Loading...

lib/shared/updates/update-thread-spec.js

Loading...