Page MenuHomePhabricator
Differential D10214

[identity] Implement attribute conversions for Device row
ClosedPublic
Actions

Authored by bartek on Dec 7 2023, 12:05 AM.
Tags
None
Referenced Files
F6273939: D10214.id34499.diff
Fri, Apr 25, 4:58 PM
F6273931: D10214.id34364.diff
Fri, Apr 25, 4:58 PM
F6273930: D10214.id.diff
Fri, Apr 25, 4:58 PM
Unknown Object (File)
Thu, Apr 24, 6:27 PM
Unknown Object (File)
Tue, Apr 22, 1:13 PM
Unknown Object (File)
Tue, Apr 22, 1:13 PM
Unknown Object (File)
Tue, Apr 22, 1:13 PM
Unknown Object (File)
Tue, Apr 22, 1:13 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
varun
Commits
rCOMM44607df0dff5: [identity] Implement attribute conversions for Device row
Summary

Added From traits to convert DeviceRow from/into AttributeValues. Copied this pattern from other services - it's very handy

Depends on D10213

Test Plan

Tested later in the stack. TODO: Add unit tests

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
services/
identity/
src/
database/
188 lines
22 lines

Diff 34499

View Options

services/identity/src/database/device_list.rs

// @flow // @flow
import uuid from 'uuid'; import uuid from 'uuid';
import blobService from '../facts/blob-service.js'; import blobService from '../facts/blob-service.js';
import type { Shape } from '../types/core.js';
import type { UploadMultimediaResult, Dimensions } from '../types/media-types'; import type { UploadMultimediaResult, Dimensions } from '../types/media-types';
import { extractKeyserverIDFromID } from '../utils/action-utils.js'; import { extractKeyserverIDFromID } from '../utils/action-utils.js';
import { toBase64URL } from '../utils/base64.js'; import { toBase64URL } from '../utils/base64.js';
import { import {
blobServiceUploadHandler, blobServiceUploadHandler,
type BlobServiceUploadHandler, type BlobServiceUploadHandler,
} from '../utils/blob-service-upload.js'; } from '../utils/blob-service-upload.js';
import { makeBlobServiceEndpointURL } from '../utils/blob-service.js'; import { makeBlobServiceEndpointURL } from '../utils/blob-service.js';
import type { CallServerEndpoint } from '../utils/call-server-endpoint.js'; import type { CallServerEndpoint } from '../utils/call-server-endpoint.js';
import { getMessageForException } from '../utils/errors.js'; import { getMessageForException } from '../utils/errors.js';
import { useKeyserverCall } from '../utils/keyserver-call.js'; import { useKeyserverCall } from '../utils/keyserver-call.js';
import type { CallKeyserverEndpoint } from '../utils/keyserver-call.js'; import type { CallKeyserverEndpoint } from '../utils/keyserver-call.js';
import { handleHTTPResponseError } from '../utils/services-utils.js'; import { handleHTTPResponseError } from '../utils/services-utils.js';
import { type UploadBlob } from '../utils/upload-blob.js'; import { type UploadBlob } from '../utils/upload-blob.js';
export type MultimediaUploadCallbacks = Shape<{ export type MultimediaUploadCallbacks = Partial<{
onProgress: (percent: number) => void, +onProgress: (percent: number) => void,
abortHandler: (abort: () => void) => void, +abortHandler: (abort: () => void) => void,
uploadBlob: UploadBlob, +uploadBlob: UploadBlob,
blobServiceUploadHandler: BlobServiceUploadHandler, +blobServiceUploadHandler: BlobServiceUploadHandler,
timeout: ?number, +timeout: ?number,
}>; }>;
export type MultimediaUploadExtras = Shape<{ export type MultimediaUploadExtras = $ReadOnly<Partial<{
...Dimensions, ...Dimensions,
loop: boolean, +loop: boolean,
encryptionKey: string, +encryptionKey: string,
thumbHash: ?string, +thumbHash: ?string,
}>; }>>;
const uploadMultimedia = const uploadMultimedia =
( (
callServerEndpoint: CallServerEndpoint, callServerEndpoint: CallServerEndpoint,
): (( ): ((
multimedia: Object, multimedia: Object,
extras: MultimediaUploadExtras, extras: MultimediaUploadExtras,
callbacks?: MultimediaUploadCallbacks, callbacks?: MultimediaUploadCallbacks,
▲ Show 20 Lines • Show All 208 Lines • Show Last 20 Lines
View Options

services/identity/src/ddb_utils.rs

// @flow // @flow
import uuid from 'uuid'; import uuid from 'uuid';
import blobService from '../facts/blob-service.js'; import blobService from '../facts/blob-service.js';
import type { Shape } from '../types/core.js';
import type { UploadMultimediaResult, Dimensions } from '../types/media-types'; import type { UploadMultimediaResult, Dimensions } from '../types/media-types';
import { extractKeyserverIDFromID } from '../utils/action-utils.js'; import { extractKeyserverIDFromID } from '../utils/action-utils.js';
import { toBase64URL } from '../utils/base64.js'; import { toBase64URL } from '../utils/base64.js';
import { import {
blobServiceUploadHandler, blobServiceUploadHandler,
type BlobServiceUploadHandler, type BlobServiceUploadHandler,
} from '../utils/blob-service-upload.js'; } from '../utils/blob-service-upload.js';
import { makeBlobServiceEndpointURL } from '../utils/blob-service.js'; import { makeBlobServiceEndpointURL } from '../utils/blob-service.js';
import type { CallServerEndpoint } from '../utils/call-server-endpoint.js'; import type { CallServerEndpoint } from '../utils/call-server-endpoint.js';
import { getMessageForException } from '../utils/errors.js'; import { getMessageForException } from '../utils/errors.js';
import { useKeyserverCall } from '../utils/keyserver-call.js'; import { useKeyserverCall } from '../utils/keyserver-call.js';
import type { CallKeyserverEndpoint } from '../utils/keyserver-call.js'; import type { CallKeyserverEndpoint } from '../utils/keyserver-call.js';
import { handleHTTPResponseError } from '../utils/services-utils.js'; import { handleHTTPResponseError } from '../utils/services-utils.js';
import { type UploadBlob } from '../utils/upload-blob.js'; import { type UploadBlob } from '../utils/upload-blob.js';
export type MultimediaUploadCallbacks = Shape<{ export type MultimediaUploadCallbacks = Partial<{
onProgress: (percent: number) => void, +onProgress: (percent: number) => void,
abortHandler: (abort: () => void) => void, +abortHandler: (abort: () => void) => void,
uploadBlob: UploadBlob, +uploadBlob: UploadBlob,
blobServiceUploadHandler: BlobServiceUploadHandler, +blobServiceUploadHandler: BlobServiceUploadHandler,
timeout: ?number, +timeout: ?number,
}>; }>;
export type MultimediaUploadExtras = Shape<{ export type MultimediaUploadExtras = $ReadOnly<Partial<{
...Dimensions, ...Dimensions,
loop: boolean, +loop: boolean,
encryptionKey: string, +encryptionKey: string,
thumbHash: ?string, +thumbHash: ?string,
}>; }>>;
const uploadMultimedia = const uploadMultimedia =
( (
callServerEndpoint: CallServerEndpoint, callServerEndpoint: CallServerEndpoint,
): (( ): ((
multimedia: Object, multimedia: Object,
extras: MultimediaUploadExtras, extras: MultimediaUploadExtras,
callbacks?: MultimediaUploadCallbacks, callbacks?: MultimediaUploadCallbacks,
▲ Show 20 Lines • Show All 208 Lines • Show Last 20 Lines