[lib] Update `convertClientDBThreadInfoToRawThreadInfo` to validate `ThreadCurrentUserInfo`
ClosedPublic
Actions

Authored by atul on Dec 12 2023, 12:30 PM.

Details

Reviewers

ashoat
ginsu
tomek
rohan

Commits

rCOMM7b262ca9855a: [lib] Update `convertClientDBThreadInfoToRawThreadInfo` to validate…

Summary

Similar to D10313 and D10298, this diff addresses what we learned when testing D10297 that it's important that we validate the stringified JSON that we retrieve from ClientDBThreadInfo. Specifically, it's possible for ClientDBThreadInfo to have either stringified MinimallyEncodedThreadCurrentInfo or ThreadCurrentInfo (yes, we didn't end up renaming this to LegacyThreadCurrentInfo because we didn't end up needing a union type, but I will change the name for symmetry) stored in the currentUser field, and we should A. validate that the data is correctly formed and B. determine what format the data is in.

Depends on D10313

Test Plan

Will be tested along with changes in D10297 and D10298 and D10313.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Dec 12 2023, 12:30 PM

atul published this revision for review.Dec 12 2023, 12:32 PM

atul added inline comments.

lib/utils/thread-ops-utils.js
54 ↗	(On Diff #34538)	Shortened so could keep the `rawCurrentUser` invariant message line under 80 characters and updated these as well to maintain symmetry. When I'm rebasing I'll probably just make the comment changes in place for cleaner diffs.

Harbormaster completed remote builds in B24997: Diff 34538.Dec 12 2023, 12:49 PM

fix (possible) minimal encoding of rawCurrentUser if not already minimally encoded.... just spent last 1.5 hours trying to figure out what was wrong, definitely going to add some invariants that would've broke "loudly" instead of erroneously encoding silently

Harbormaster completed remote builds in B25008: Diff 34549.Dec 12 2023, 2:33 PM

atul added a child revision: D10325: [lib] Add runtime check to `minimallyEncodeThreadCurrentUserInfo` ensure argument isn't already minimally encoded.Dec 12 2023, 2:58 PM

ashoat accepted this revision.Dec 12 2023, 4:52 PM

This revision is now accepted and ready to land.Dec 12 2023, 4:52 PM

atul mentioned this in D10210: [lib] Introduce `deprecatedConvertClientDBThreadInfoToRawThreadInfo`.Dec 13 2023, 1:15 PM

land

This revision was landed with ongoing or failed builds.Dec 13 2023, 1:34 PM

Closed by commit rCOMM7b262ca9855a: [lib] Update `convertClientDBThreadInfoToRawThreadInfo` to validate… (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM7b262ca9855a: [lib] Update `convertClientDBThreadInfoToRawThreadInfo` to validate….

Harbormaster completed remote builds in B25033: Diff 34584.Dec 13 2023, 2:25 PM