[native] Add branching to `fixUnreadActiveThread` to support `RawThreadInfos`
ClosedPublic
Actions

Authored by atul on Dec 8 2023, 1:32 PM.

Details

Reviewers

ashoat
ginsu
tomek
rohan

Commits

rCOMMd60b068457c1: [native] Add branching to `fixUnreadActiveThread` to support `RawThreadInfos`

Summary

Same as much of the stack before, we need to add branching to support both LeagacyThreadInfos and MinimallyEncodedThreadInfos.

There's a lot of cut/paste here. I'm currently focused on getting to 0 flow issues across the codebase, but will come back and try to tidy these up before landing to avoid cluttering up codebase w/ noise.

NOTE: CI is expected to fail. I got to a point in my local environment where all flow issues were resolved, but based on earlier fedback in the stack I'm breaking them down so things are easier to review.. even if that means that intermediate steps fail.

[skip-ci]

Depends on D10278

Test Plan

flow/CI/etc.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 25048
Build 218736: arc lint + arc unit

Event Timeline

atul requested review of this revision.Dec 8 2023, 1:32 PM

atul created this revision.

Harbormaster completed remote builds in B24926: Diff 34460.Dec 8 2023, 1:32 PM

atul added a child revision: D10281: [native] Introduce `assertAllThreadInfosAreLegacy` to address migration 29 `flow` issues.Dec 8 2023, 1:54 PM

ashoat requested changes to this revision.Dec 11 2023, 8:49 PM

ashoat added inline comments.

native/redux/redux-setup.js
318–376 ↗	(On Diff #34460)	Same comment as here

This revision now requires changes to proceed.Dec 11 2023, 8:49 PM

last rebase pass

from D10274 (https://phab.comm.dev/D10274#298939)

will address these flow refactors at the end of the stack.

totally realize it would be better to update diff where the change was introduced, but it's a little tricky here because we have flow issues at this part of the stack. it's easier to make these noop refactors at the end of the stack where we have 0 flow issues as a baseline.

Harbormaster completed remote builds in B25048: Diff 34608.Dec 13 2023, 3:03 PM

Before landing, can you link the diff where it's addressed, or a Linear task that tracks it? (Linear task must make explicit mention of these diff comments)

This revision is now accepted and ready to land.Dec 14 2023, 9:46 AM

In D10280#299275, @ashoat wrote:

Before landing, can you link the diff where it's addressed, or a Linear task that tracks it? (Linear task must make explicit mention of these diff comments)

https://linear.app/comm/issue/ENG-6070/tidy-up-flow-branching-from-minimal-permissions-work

Closed by commit rCOMMd60b068457c1: [native] Add branching to `fixUnreadActiveThread` to support `RawThreadInfos` (authored by atul). · Explain WhyDec 14 2023, 12:49 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMd60b068457c1: [native] Add branching to `fixUnreadActiveThread` to support `RawThreadInfos`.