Paths

Table of Contentst

[keyserver] Move `threadStoreValidator` to `redux-state-responders`
ClosedPublic
Actions

Authored by atul on Dec 11 2023, 12:41 PM.

Details

Reviewers

ashoat
ginsu
tomek
rohan

Commits

rCOMMb780797c5e95: [keyserver] Move `threadStoreValidator` to `redux-state-responders`

Summary

This diff is a follow-up diff to D10294.

Initially when I tried updating threadStoreValidator I had some issues with Jest... and as before it was a circular dependency issue.

Since threadStoreValidator is only being used by initialReduxStateValidator, I moved it right beside (above) it.

Depends on D10294

Test Plan

CI/flow/etc. Will become clear whether or not this validator works when we get to web.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Dec 11 2023, 12:41 PM

atul published this revision for review.Dec 11 2023, 12:42 PM

Harbormaster completed remote builds in B24952: Diff 34489.Dec 11 2023, 12:59 PM

atul added a child revision: D10296: [lib] Fix `threadPermissionsFromBitmaskHex` invariant.Dec 11 2023, 2:23 PM

ashoat accepted this revision.Dec 11 2023, 8:32 PM

This revision is now accepted and ready to land.Dec 11 2023, 8:32 PM

land

Harbormaster failed remote builds in B25035: Diff 34595!Dec 13 2023, 2:08 PM

final rebase pass

Harbormaster completed remote builds in B25055: Diff 34615.Dec 13 2023, 4:26 PM

Closed by commit rCOMMb780797c5e95: [keyserver] Move `threadStoreValidator` to `redux-state-responders` (authored by atul). · Explain WhyDec 14 2023, 1:03 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMb780797c5e95: [keyserver] Move `threadStoreValidator` to `redux-state-responders`.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

responders/

redux-state-responders.js

10 lines

lib/

types/

thread-types.js

4 lines

Diff 34615

View Options

keyserver/src/responders/redux-state-responders.js