Paths

Table of Contentst

Differential D10379

[lib/native] introduce handling Tunnelbroker peer-to-peer messages
ClosedPublic
Actions

Authored by kamil on Dec 18 2023, 4:48 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Oct 18, 2:08 AM

	Unknown Object (File)
	Fri, Oct 18, 2:08 AM

	Unknown Object (File)
	Fri, Oct 18, 2:08 AM

	Unknown Object (File)
	Fri, Oct 18, 2:08 AM

	Unknown Object (File)
	Fri, Oct 18, 2:08 AM

	Unknown Object (File)
	Fri, Oct 18, 2:08 AM

	Unknown Object (File)
	Thu, Oct 10, 5:33 AM

	Unknown Object (File)
	Sep 6 2024, 7:37 PM

View All 68 Files

Subscribers

Details

Reviewers

marcin
varun
michal

Commits

rCOMMce039ddbcdee: [lib/native] introduce handling Tunnelbroker peer-to-peer messages

Summary

This adds:

Types od messages which is sent as payload of MessageToDevice between peers
Validators
Allow Tunnelbroker socket to call handler specific for platform

Depends on D10378

Test Plan

Tested in next diffs and end-to-end in [link to diff]

Diff Detail

Repository

Branch

publish-olm-stack

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Dec 18 2023, 4:48 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 18 2023, 4:48 AM

kamil added a child revision: D10380: [native] implement accepting `olm` session.Dec 18 2023, 5:49 AM

kamil published this revision for review.Dec 18 2023, 6:53 AM

Harbormaster completed remote builds in B25178: Diff 34793.Dec 18 2023, 7:09 AM

ashoat added inline comments.Dec 18 2023, 11:03 AM

lib/types/tunnelbroker/peer-to-peer-message-types.js
17–20	We can now consider using Flow enums for these, as we have all of the requirements. There are 3 steps to enable them, but you might not have the cycles for this right now. Just figured I'd flag

kamil added inline comments.Jan 3 2024, 7:24 AM

lib/types/tunnelbroker/peer-to-peer-message-types.js
17–20	Note for reviewers: this should not be numbers but strings, because later we need to add `REFRESH_KEY_REQUEST: 'RefreshKeyRequest',` which is sent by Identity, I'll update this shortly

kamil mentioned this in D10383: [native] add button to test send encrypted content between devices.Jan 5 2024, 2:52 AM

michal accepted this revision.Jan 8 2024, 3:42 AM

michal added inline comments.

lib/tunnelbroker/tunnelbroker-context.js
52	This is more general and allows both sync and async functions

This revision is now accepted and ready to land.Jan 8 2024, 3:42 AM

address review

Harbormaster failed remote builds in B25612: Diff 35407!Jan 8 2024, 10:16 AM

kamil requested review of this revision.Jan 9 2024, 2:50 AM

kamil added 1 blocking reviewer(s): michal.

kamil mentioned this in D10511: [lib/shared] clean `RefreshKeyRequest` type.

michal accepted this revision.Jan 9 2024, 3:01 AM

michal added inline comments.

lib/tunnelbroker/tunnelbroker-context.js
166 ↗	(On Diff #35407)	Do we still need void here after changing the return type to `mixed`?
lib/types/tunnelbroker/peer-to-peer-message-types.js
54 ↗	(On Diff #35407)

This revision is now accepted and ready to land.Jan 9 2024, 3:01 AM

address review

Harbormaster completed remote builds in B25650: Diff 35463.Jan 10 2024, 3:53 AM

Closed by commit rCOMMce039ddbcdee: [lib/native] introduce handling Tunnelbroker peer-to-peer messages (authored by kamil). · Explain WhyJan 11 2024, 5:28 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMce039ddbcdee: [lib/native] introduce handling Tunnelbroker peer-to-peer messages.

kamil mentioned this in rCOMM10771ee94c00: [lib/shared] clean `RefreshKeyRequest` type.

Revision Contents
Changeset List

Path

Size

lib/

tunnelbroker/

tunnelbroker-context.js

37 lines

types/

tunnelbroker/

peer-to-peer-message-types.js

50 lines

native/

handlers/

peer-to-peer-message-handler.js

18 lines

6 lines

Diff 34793

lib/tunnelbroker/tunnelbroker-context.js

Loading...

lib/types/tunnelbroker/peer-to-peer-message-types.js

Loading...

native/handlers/peer-to-peer-message-handler.js

Loading...

native/root.react.js

Loading...