[native] add button to test send encrypted content between devices
ClosedPublic
Actions

Authored by kamil on Dec 18 2023, 6:07 AM.

Details

Reviewers

varun
michal
marcin

Commits

rCOMM071147b1d546: [native] add button to test send encrypted content between devices

Summary

Sending encrypted messages to different devices.
As a follow-up, we can consider adding some alerts to make it easier to test on prod but still, at current state it could only be tested on the dev end.

Depends on D10382

Test Plan

This is the last diff on which I tested everything end-to-end

Two devices on the same account
Connected to staging Identity and Tunnelbroker
Created a session (D10382)
Verified that session is created on both devices
Use this to send encrypted message to device (both ways)
Look at logs and test if message is decrypted

Diff Detail

Repository

rCOMM Comm

Branch

publish-olm-stack

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Dec 18 2023, 6:07 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 18 2023, 6:07 AM

kamil added a child revision: D10384: [CryptoModule] rename `targetUserId` -> `targetDeviceId`.Dec 18 2023, 6:09 AM

kamil published this revision for review.Dec 18 2023, 6:55 AM

Harbormaster completed remote builds in B25182: Diff 34797.Dec 18 2023, 7:41 AM

@michal should have more context on react to give thorough review.

michal added inline comments.Jan 4 2024, 5:34 AM

native/profile/tunnelbroker-menu.react.js
78	Why are we using a dummy id here?

kamil added inline comments.Jan 5 2024, 2:52 AM

native/profile/tunnelbroker-menu.react.js
78	I introduced `SenderInfo` (D10379) as `deviceID` and `userID` as I believe at some point those two will be needed. Right now, we only need `deviceID` which is the key to getting `olm` session, and `userID` is not used in the current state. Since in this component we don't have `userID` (Identity `userID`) used a dummy id as it was easier, it's only a test screen anyway. I can add a comment explaining or get `userID` from `commCoreModule` - what you think it's better.

ashoat added inline comments.Jan 5 2024, 6:06 AM

native/profile/tunnelbroker-menu.react.js
78	Identity `userID` should be the same as the normal `userID`. You can probably get this from Redux?

kamil removed a child revision: D10384: [CryptoModule] rename `targetUserId` -> `targetDeviceId`.Jan 8 2024, 6:54 AM

fix line width
use userID from Redux

kamil added inline comments.Jan 9 2024, 2:40 AM

native/profile/tunnelbroker-menu.react.js
78	Identity `userID` should be the same as the normal `userID`. You can probably get this from Redux? At the current state, while testing with staging those two are different - but since it doesn't make any change I can use it from `Redux` for clarity