[CommCoreModule] implement encrypting content with `olm` session
ClosedPublic
Actions

Authored by kamil on Dec 18 2023, 12:40 PM.

Details

Reviewers

marcin
varun
michal

Commits

rCOMM436eb8a4d54c: [CommCoreModule] implement encrypting content with `olm` session

Summary

Implemented method to encrypt content.

Depends on D10376

Test Plan

This code is really hard to test as it's impossible to verify partial results.
I generated some keys and values, verified them with olm-utils.test.js, and checked if they succeeded/failed when calling the method introduced here in the same cases as JS tests.
Full functionality tested later in the stack.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Dec 18 2023, 12:40 PM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 18 2023, 12:40 PM

kamil added a child revision: D10378: [CommCoreModule] implement decrypting content with `olm` session.Dec 18 2023, 12:42 PM

Harbormaster completed remote builds in B25176: Diff 34791.Dec 18 2023, 2:47 PM

kamil published this revision for review.Dec 18 2023, 2:51 PM

marcin requested changes to this revision.Dec 21 2023, 11:23 AM

marcin added inline comments.

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
831 ↗	(On Diff #34791)	This comment is relevant here as well.

This revision now requires changes to proceed.Dec 21 2023, 11:23 AM

rebase

Harbormaster completed remote builds in B25439: Diff 35143.Jan 2 2024, 5:43 PM

marcin added inline comments.Jan 3 2024, 7:55 AM

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
823 ↗	(On Diff #35143)	The term `initialEncryptedMessage` should be reserved for inbound session creation. Using it for an ordinary encrypted message is confusing to the reader. Please rename it to `encryptedMessage` before landing.