Page MenuHomePhabricator

[keyserver] Create invite link blobs in a migration
ClosedPublic

Authored by tomek on Feb 14 2024, 7:05 AM.
Tags
None
Referenced Files
F1934367: D11076.id37077.diff
Sun, Jun 2, 1:30 PM
Unknown Object (File)
Fri, May 31, 6:24 PM
Unknown Object (File)
Thu, May 23, 1:47 AM
Unknown Object (File)
Mon, May 20, 10:29 AM
Unknown Object (File)
Mon, May 20, 10:29 AM
Unknown Object (File)
Mon, May 20, 10:29 AM
Unknown Object (File)
Mon, May 20, 10:29 AM
Unknown Object (File)
Sun, May 19, 9:47 PM
Subscribers

Details

Summary

In D10206 we're running this in cron, but we also should do that in a migration - this isn't strictly necessary because cron would update it later, but it is better to do that immediately.

Additionally, the function was modified so that the migration / job doesn't fail in environments where we aren't authenticated to Identity service.

Depends on D11051

Test Plan

Run the keyserver and check if the migration creates holders in invite_links table.
Kill the keyserver, delete auth metadata, decrement db version, delete the holder and update invite link secret. Then run the keyserver - the migration should succeed by printing an error message - the holder shouldn't be created.

Diff Detail

Repository
rCOMM Comm
Branch
linki (branched from palys-swm/linki)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek requested review of this revision.Feb 14 2024, 7:21 AM
This revision is now accepted and ready to land.Feb 14 2024, 7:46 AM
keyserver/src/utils/synchronizeInviteLinksWithBlobs.js
44 ↗(On Diff #37098)

Will monitor for this string next time I deploy the keyserver