Paths

Table of Contentst

-
lib/
-
permissions/
-
minimally-encoded-thread-permissions-test-data.js
-
special-roles.js
-
special-roles.test.js
-
reducers/
-
calendar-filters-reducer.test.js
-
shared/
-
thread-utils.test.js
-
types/
-
minimally-encoded-thread-permissions-types.js

[lib] Make `specialRoles` field of `RoleInfo` required
AbandonedPublic
Actions

Authored by atul on Mar 5 2024, 9:20 PM.

Details

Reviewers

tomek
ginsu
michal
kamil

Summary

We now expect clients to get RoleInfos with the specialRole field included. We make the field required (it's still ?SpecialRole, so can be set to null) and make the necessary flow changes.

Depends on D11248

Test Plan

flow + verifying that clients recieve specialRole field in RoleInfo from keyserver responses.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Mar 5 2024, 9:20 PM

Herald added a subscriber: ashoat. · View Herald TranscriptMar 5 2024, 9:20 PM

atul added a child revision: D11253: [lib] Remove `isDefault` field from `RoleInfo`.Mar 5 2024, 9:28 PM

fix else case of patchRoleInfoWithSpecialRole

Harbormaster completed remote builds in B27349: Diff 37871.Mar 5 2024, 9:35 PM

Harbormaster completed remote builds in B27351: Diff 37873.Mar 5 2024, 9:51 PM

atul requested review of this revision.Mar 5 2024, 9:51 PM

tomek accepted this revision.Mar 6 2024, 4:21 AM

tomek added inline comments.

lib/types/minimally-encoded-thread-permissions-types.js
37	Maybe add an explicit null?

This revision is now accepted and ready to land.Mar 6 2024, 4:21 AM

We ended up going with a very different approach from this stack. Abandoning to tidy things up.

Revision Contents
Changeset List

Path

Size

lib/

permissions/

minimally-encoded-thread-permissions-test-data.js

2 lines

special-roles.js

6 lines

special-roles.test.js

12 lines

reducers/

calendar-filters-reducer.test.js

4 lines

shared/

thread-utils.test.js

3 lines

types/

minimally-encoded-thread-permissions-types.js

11 lines

Diff 37873

View Options

lib/permissions/minimally-encoded-thread-permissions-test-data.js

Show First 20 Lines • Show All 841 Lines • ▼ Show 20 Lines	RNSVG:
:path: "../node_modules/react-native-svg"		:path: "../node_modules/react-native-svg"
SQLCipher-Amalgamation:		SQLCipher-Amalgamation:
:path: "../../node_modules/@commapp/sqlcipher-amalgamation"		:path: "../../node_modules/@commapp/sqlcipher-amalgamation"
Yoga:		Yoga:
:path: "../../node_modules/react-native/ReactCommon/yoga"		:path: "../../node_modules/react-native/ReactCommon/yoga"

SPEC CHECKSUMS:		SPEC CHECKSUMS:
boost: a7c83b31436843459a1961bfd74b96033dc77234		boost: a7c83b31436843459a1961bfd74b96033dc77234
CommExpoPackage: 3f9d8a25537fb9d80f79a63fd1e73c51f55b87e9		CommExpoPackage: ed5b817b93a97c687a6eaacd8883a015159e7e99
DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54		DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54
DVAssetLoaderDelegate: 0caec20e4e08b8560b691131539e9180024d4bce		DVAssetLoaderDelegate: 0caec20e4e08b8560b691131539e9180024d4bce
EXApplication: d8f53a7eee90a870a75656280e8d4b85726ea903		EXApplication: d8f53a7eee90a870a75656280e8d4b85726ea903
EXBarCodeScanner: cb4deb49e59b6c7ed6bbf38d187802359908d2a8		EXBarCodeScanner: cb4deb49e59b6c7ed6bbf38d187802359908d2a8
EXConstants: 3c86653c422dd77e40d10cbbabb3025003977415		EXConstants: 3c86653c422dd77e40d10cbbabb3025003977415
EXFileSystem: 60602b6eefa6873f97172c684b7537c9760b50d6		EXFileSystem: 60602b6eefa6873f97172c684b7537c9760b50d6
EXFont: 319606bfe48c33b5b5063fb0994afdc496befe80		EXFont: 319606bfe48c33b5b5063fb0994afdc496befe80
EXImageLoader: 84b65e6bd9d3345d6fbb3ab936a546c54496a64d		EXImageLoader: 84b65e6bd9d3345d6fbb3ab936a546c54496a64d
▲ Show 20 Lines • Show All 82 Lines • ▼ Show 20 Lines	SPEC CHECKSUMS:
SDWebImageAVIFCoder: d759e21cf4efb640cc97250566aa556ad8bb877c		SDWebImageAVIFCoder: d759e21cf4efb640cc97250566aa556ad8bb877c
SDWebImageSVGCoder: 6fc109f9c2a82ab44510fff410b88b1a6c271ee8		SDWebImageSVGCoder: 6fc109f9c2a82ab44510fff410b88b1a6c271ee8
SDWebImageWebPCoder: 18503de6621dd2c420d680e33d46bf8e1d5169b0		SDWebImageWebPCoder: 18503de6621dd2c420d680e33d46bf8e1d5169b0
SPTPersistentCache: df36ea46762d7cf026502bbb86a8b79d0080dff4		SPTPersistentCache: df36ea46762d7cf026502bbb86a8b79d0080dff4
SQLCipher-Amalgamation: cbd36045fe7b458b8a442958a01aefdbc44c20f8		SQLCipher-Amalgamation: cbd36045fe7b458b8a442958a01aefdbc44c20f8
Yoga: dc109b79db907f0f589fc423e991b09ec42d2295		Yoga: dc109b79db907f0f589fc423e991b09ec42d2295
ZXingObjC: fdbb269f25dd2032da343e06f10224d62f537bdb		ZXingObjC: fdbb269f25dd2032da343e06f10224d62f537bdb

PODFILE CHECKSUM: e45238be1b6262e5cd4dbe34492a16945fc2ae43		PODFILE CHECKSUM: 8b75c667b4679ba1a92a975823401ba7614ea7a1

COCOAPODS: 1.12.1		COCOAPODS: 1.12.1

View Options

lib/permissions/special-roles.js

Show First 20 Lines • Show All 841 Lines • ▼ Show 20 Lines	RNSVG:
:path: "../node_modules/react-native-svg"		:path: "../node_modules/react-native-svg"
SQLCipher-Amalgamation:		SQLCipher-Amalgamation:
:path: "../../node_modules/@commapp/sqlcipher-amalgamation"		:path: "../../node_modules/@commapp/sqlcipher-amalgamation"
Yoga:		Yoga:
:path: "../../node_modules/react-native/ReactCommon/yoga"		:path: "../../node_modules/react-native/ReactCommon/yoga"

SPEC CHECKSUMS:		SPEC CHECKSUMS:
boost: a7c83b31436843459a1961bfd74b96033dc77234		boost: a7c83b31436843459a1961bfd74b96033dc77234
CommExpoPackage: 3f9d8a25537fb9d80f79a63fd1e73c51f55b87e9		CommExpoPackage: ed5b817b93a97c687a6eaacd8883a015159e7e99
DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54		DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54
DVAssetLoaderDelegate: 0caec20e4e08b8560b691131539e9180024d4bce		DVAssetLoaderDelegate: 0caec20e4e08b8560b691131539e9180024d4bce
EXApplication: d8f53a7eee90a870a75656280e8d4b85726ea903		EXApplication: d8f53a7eee90a870a75656280e8d4b85726ea903
EXBarCodeScanner: cb4deb49e59b6c7ed6bbf38d187802359908d2a8		EXBarCodeScanner: cb4deb49e59b6c7ed6bbf38d187802359908d2a8
EXConstants: 3c86653c422dd77e40d10cbbabb3025003977415		EXConstants: 3c86653c422dd77e40d10cbbabb3025003977415
EXFileSystem: 60602b6eefa6873f97172c684b7537c9760b50d6		EXFileSystem: 60602b6eefa6873f97172c684b7537c9760b50d6
EXFont: 319606bfe48c33b5b5063fb0994afdc496befe80		EXFont: 319606bfe48c33b5b5063fb0994afdc496befe80
EXImageLoader: 84b65e6bd9d3345d6fbb3ab936a546c54496a64d		EXImageLoader: 84b65e6bd9d3345d6fbb3ab936a546c54496a64d
▲ Show 20 Lines • Show All 82 Lines • ▼ Show 20 Lines	SPEC CHECKSUMS:
SDWebImageAVIFCoder: d759e21cf4efb640cc97250566aa556ad8bb877c		SDWebImageAVIFCoder: d759e21cf4efb640cc97250566aa556ad8bb877c
SDWebImageSVGCoder: 6fc109f9c2a82ab44510fff410b88b1a6c271ee8		SDWebImageSVGCoder: 6fc109f9c2a82ab44510fff410b88b1a6c271ee8
SDWebImageWebPCoder: 18503de6621dd2c420d680e33d46bf8e1d5169b0		SDWebImageWebPCoder: 18503de6621dd2c420d680e33d46bf8e1d5169b0
SPTPersistentCache: df36ea46762d7cf026502bbb86a8b79d0080dff4		SPTPersistentCache: df36ea46762d7cf026502bbb86a8b79d0080dff4
SQLCipher-Amalgamation: cbd36045fe7b458b8a442958a01aefdbc44c20f8		SQLCipher-Amalgamation: cbd36045fe7b458b8a442958a01aefdbc44c20f8
Yoga: dc109b79db907f0f589fc423e991b09ec42d2295		Yoga: dc109b79db907f0f589fc423e991b09ec42d2295
ZXingObjC: fdbb269f25dd2032da343e06f10224d62f537bdb		ZXingObjC: fdbb269f25dd2032da343e06f10224d62f537bdb

PODFILE CHECKSUM: e45238be1b6262e5cd4dbe34492a16945fc2ae43		PODFILE CHECKSUM: 8b75c667b4679ba1a92a975823401ba7614ea7a1

COCOAPODS: 1.12.1		COCOAPODS: 1.12.1

View Options

lib/permissions/special-roles.test.js

Show First 20 Lines • Show All 841 Lines • ▼ Show 20 Lines	RNSVG:
:path: "../node_modules/react-native-svg"		:path: "../node_modules/react-native-svg"
SQLCipher-Amalgamation:		SQLCipher-Amalgamation:
:path: "../../node_modules/@commapp/sqlcipher-amalgamation"		:path: "../../node_modules/@commapp/sqlcipher-amalgamation"
Yoga:		Yoga:
:path: "../../node_modules/react-native/ReactCommon/yoga"		:path: "../../node_modules/react-native/ReactCommon/yoga"

SPEC CHECKSUMS:		SPEC CHECKSUMS:
boost: a7c83b31436843459a1961bfd74b96033dc77234		boost: a7c83b31436843459a1961bfd74b96033dc77234
CommExpoPackage: 3f9d8a25537fb9d80f79a63fd1e73c51f55b87e9		CommExpoPackage: ed5b817b93a97c687a6eaacd8883a015159e7e99
DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54		DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54
DVAssetLoaderDelegate: 0caec20e4e08b8560b691131539e9180024d4bce		DVAssetLoaderDelegate: 0caec20e4e08b8560b691131539e9180024d4bce
EXApplication: d8f53a7eee90a870a75656280e8d4b85726ea903		EXApplication: d8f53a7eee90a870a75656280e8d4b85726ea903
EXBarCodeScanner: cb4deb49e59b6c7ed6bbf38d187802359908d2a8		EXBarCodeScanner: cb4deb49e59b6c7ed6bbf38d187802359908d2a8
EXConstants: 3c86653c422dd77e40d10cbbabb3025003977415		EXConstants: 3c86653c422dd77e40d10cbbabb3025003977415
EXFileSystem: 60602b6eefa6873f97172c684b7537c9760b50d6		EXFileSystem: 60602b6eefa6873f97172c684b7537c9760b50d6
EXFont: 319606bfe48c33b5b5063fb0994afdc496befe80		EXFont: 319606bfe48c33b5b5063fb0994afdc496befe80
EXImageLoader: 84b65e6bd9d3345d6fbb3ab936a546c54496a64d		EXImageLoader: 84b65e6bd9d3345d6fbb3ab936a546c54496a64d
▲ Show 20 Lines • Show All 82 Lines • ▼ Show 20 Lines	SPEC CHECKSUMS:
SDWebImageAVIFCoder: d759e21cf4efb640cc97250566aa556ad8bb877c		SDWebImageAVIFCoder: d759e21cf4efb640cc97250566aa556ad8bb877c
SDWebImageSVGCoder: 6fc109f9c2a82ab44510fff410b88b1a6c271ee8		SDWebImageSVGCoder: 6fc109f9c2a82ab44510fff410b88b1a6c271ee8
SDWebImageWebPCoder: 18503de6621dd2c420d680e33d46bf8e1d5169b0		SDWebImageWebPCoder: 18503de6621dd2c420d680e33d46bf8e1d5169b0
SPTPersistentCache: df36ea46762d7cf026502bbb86a8b79d0080dff4		SPTPersistentCache: df36ea46762d7cf026502bbb86a8b79d0080dff4
SQLCipher-Amalgamation: cbd36045fe7b458b8a442958a01aefdbc44c20f8		SQLCipher-Amalgamation: cbd36045fe7b458b8a442958a01aefdbc44c20f8
Yoga: dc109b79db907f0f589fc423e991b09ec42d2295		Yoga: dc109b79db907f0f589fc423e991b09ec42d2295
ZXingObjC: fdbb269f25dd2032da343e06f10224d62f537bdb		ZXingObjC: fdbb269f25dd2032da343e06f10224d62f537bdb

PODFILE CHECKSUM: e45238be1b6262e5cd4dbe34492a16945fc2ae43		PODFILE CHECKSUM: 8b75c667b4679ba1a92a975823401ba7614ea7a1

COCOAPODS: 1.12.1		COCOAPODS: 1.12.1

View Options

lib/reducers/calendar-filters-reducer.test.js

Show First 20 Lines • Show All 841 Lines • ▼ Show 20 Lines	RNSVG:
:path: "../node_modules/react-native-svg"		:path: "../node_modules/react-native-svg"
SQLCipher-Amalgamation:		SQLCipher-Amalgamation:
:path: "../../node_modules/@commapp/sqlcipher-amalgamation"		:path: "../../node_modules/@commapp/sqlcipher-amalgamation"
Yoga:		Yoga:
:path: "../../node_modules/react-native/ReactCommon/yoga"		:path: "../../node_modules/react-native/ReactCommon/yoga"

SPEC CHECKSUMS:		SPEC CHECKSUMS:
boost: a7c83b31436843459a1961bfd74b96033dc77234		boost: a7c83b31436843459a1961bfd74b96033dc77234
CommExpoPackage: 3f9d8a25537fb9d80f79a63fd1e73c51f55b87e9		CommExpoPackage: ed5b817b93a97c687a6eaacd8883a015159e7e99
DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54		DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54
DVAssetLoaderDelegate: 0caec20e4e08b8560b691131539e9180024d4bce		DVAssetLoaderDelegate: 0caec20e4e08b8560b691131539e9180024d4bce
EXApplication: d8f53a7eee90a870a75656280e8d4b85726ea903		EXApplication: d8f53a7eee90a870a75656280e8d4b85726ea903
EXBarCodeScanner: cb4deb49e59b6c7ed6bbf38d187802359908d2a8		EXBarCodeScanner: cb4deb49e59b6c7ed6bbf38d187802359908d2a8
EXConstants: 3c86653c422dd77e40d10cbbabb3025003977415		EXConstants: 3c86653c422dd77e40d10cbbabb3025003977415
EXFileSystem: 60602b6eefa6873f97172c684b7537c9760b50d6		EXFileSystem: 60602b6eefa6873f97172c684b7537c9760b50d6
EXFont: 319606bfe48c33b5b5063fb0994afdc496befe80		EXFont: 319606bfe48c33b5b5063fb0994afdc496befe80
EXImageLoader: 84b65e6bd9d3345d6fbb3ab936a546c54496a64d		EXImageLoader: 84b65e6bd9d3345d6fbb3ab936a546c54496a64d
▲ Show 20 Lines • Show All 82 Lines • ▼ Show 20 Lines	SPEC CHECKSUMS:
SDWebImageAVIFCoder: d759e21cf4efb640cc97250566aa556ad8bb877c		SDWebImageAVIFCoder: d759e21cf4efb640cc97250566aa556ad8bb877c
SDWebImageSVGCoder: 6fc109f9c2a82ab44510fff410b88b1a6c271ee8		SDWebImageSVGCoder: 6fc109f9c2a82ab44510fff410b88b1a6c271ee8
SDWebImageWebPCoder: 18503de6621dd2c420d680e33d46bf8e1d5169b0		SDWebImageWebPCoder: 18503de6621dd2c420d680e33d46bf8e1d5169b0
SPTPersistentCache: df36ea46762d7cf026502bbb86a8b79d0080dff4		SPTPersistentCache: df36ea46762d7cf026502bbb86a8b79d0080dff4
SQLCipher-Amalgamation: cbd36045fe7b458b8a442958a01aefdbc44c20f8		SQLCipher-Amalgamation: cbd36045fe7b458b8a442958a01aefdbc44c20f8
Yoga: dc109b79db907f0f589fc423e991b09ec42d2295		Yoga: dc109b79db907f0f589fc423e991b09ec42d2295
ZXingObjC: fdbb269f25dd2032da343e06f10224d62f537bdb		ZXingObjC: fdbb269f25dd2032da343e06f10224d62f537bdb

PODFILE CHECKSUM: e45238be1b6262e5cd4dbe34492a16945fc2ae43		PODFILE CHECKSUM: 8b75c667b4679ba1a92a975823401ba7614ea7a1

COCOAPODS: 1.12.1		COCOAPODS: 1.12.1

View Options

lib/shared/thread-utils.test.js

View Options

lib/types/minimally-encoded-thread-permissions-types.js

[lib] Make `specialRoles` field of `RoleInfo` requiredAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 37873

lib/permissions/minimally-encoded-thread-permissions-test-data.js

lib/permissions/special-roles.js

lib/permissions/special-roles.test.js

lib/reducers/calendar-filters-reducer.test.js

lib/shared/thread-utils.test.js

lib/types/minimally-encoded-thread-permissions-types.js

[lib] Make `specialRoles` field of `RoleInfo` required
AbandonedPublic
Actions

Revision Contents
Changeset List