Page MenuHomePhabricator
Differential D11286

[lib] Introduce `persistedRoleInfoValidator` and use in `convertClientDBThreadInfoToRawThreadInfo`
ClosedPublic
Actions

Authored by atul on Mar 10 2024, 12:52 PM.
Tags
None
Referenced Files
F3362933: D11286.id38194.diff
Sun, Nov 24, 11:34 PM
F3362932: D11286.id38192.diff
Sun, Nov 24, 11:34 PM
F3362083: D11286.diff
Sun, Nov 24, 9:21 PM
Unknown Object (File)
Tue, Nov 12, 11:38 AM
Unknown Object (File)
Fri, Nov 8, 5:20 PM
Unknown Object (File)
Fri, Nov 8, 2:12 PM
Unknown Object (File)
Thu, Nov 7, 2:38 AM
Unknown Object (File)
Oct 15 2024, 8:04 PM
View All 70 Files
Subscribers
ashoat

Details

Reviewers
ginsu
tomek
michal
kamil
Commits
rCOMM413c7b519700: [lib] Introduce `persistedRoleInfoValidator` and use in…
Summary

In convertClientDBThreadInfoToRawThreadInfo we validate contents of persisted RoleInfos before any migrations are run. After removing isDefault from RoleInfo and roleInfoValidator, we need to handle case where user has persisted RoleInfos WITH the isDefault field included. Otherwise we'll get an error something like this:

Depends on D11276

Test Plan
  • Unit test
  • Installed and logged into old version of native
  • Updated to master, observed that I didn't see the message above:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Mar 10 2024, 12:52 PM
Herald added a subscriber: ashoat. · View Herald TranscriptMar 10 2024, 12:52 PM
Harbormaster completed remote builds in B27409: Diff 37957.Mar 10 2024, 1:08 PM
atul requested review of this revision.Mar 10 2024, 1:08 PM
atul added a child revision: D11288: [lib] Remove `threadOrParentThreadHasAdminRole` check from `threadIsWithBlockedUserOnly`.Mar 11 2024, 1:06 AM
ashoat added inline comments.Mar 11 2024, 10:43 AM
lib/permissions/minimally-encoded-raw-thread-info-validators.js
39–42 ↗(On Diff #37957)

Read-only?

atul added a child revision: D11308: [native][web] Update `ChatInputBar` to pass `communityThreadInfo` to `threadFrozenDueToViewerBlock`.Mar 11 2024, 2:12 PM
tomek accepted this revision.Mar 19 2024, 5:01 AM
This revision is now accepted and ready to land.Mar 19 2024, 5:01 AM
atul updated this revision to Diff 38192.Mar 19 2024, 10:08 AM

rebase around everything and land

atul updated this revision to Diff 38194.Mar 19 2024, 10:16 AM

make things read-only

This revision was landed with ongoing or failed builds.Mar 19 2024, 10:22 AM
Closed by commit rCOMM413c7b519700: [lib] Introduce `persistedRoleInfoValidator` and use in… (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM413c7b519700: [lib] Introduce `persistedRoleInfoValidator` and use in….
Harbormaster completed remote builds in B27600: Diff 38192.Mar 19 2024, 10:32 AM
Harbormaster completed remote builds in B27602: Diff 38194.Mar 19 2024, 10:35 AM
atul mentioned this in D11496: [lib] Fix keyserver sending updated RoleInfos to old clients.Apr 1 2024, 12:43 PM

Revision Contents
Changeset List

Diff 38195

View Options

lib/permissions/minimally-encoded-raw-thread-info-validators.js

Loading...
View Options

lib/permissions/minimally-encoded-thread-permissions.test.js

Loading...
View Options

lib/utils/thread-ops-utils.js

Loading...