Page MenuHomePhabricator
Differential D11208

[lib] Deprecate `useRoleDeletableAndEditableStatus` and determine `is[Editable/Deletable]` directly in `RoleActionsMenu`
ClosedPublic
Actions

Authored by atul on Mar 1 2024, 12:57 PM.
Tags
None
Referenced Files
F3362085: D11208.id38199.diff
Sun, Nov 24, 9:21 PM
Unknown Object (File)
Wed, Nov 20, 6:22 PM
Unknown Object (File)
Thu, Nov 7, 3:17 AM
Unknown Object (File)
Oct 15 2024, 9:04 PM
Unknown Object (File)
Oct 15 2024, 9:04 PM
Unknown Object (File)
Oct 15 2024, 9:04 PM
Unknown Object (File)
Oct 15 2024, 9:04 PM
Unknown Object (File)
Oct 15 2024, 9:04 PM
View All 53 Files
Subscribers
ashoat

Details

Reviewers
ginsu
tomek
kamil
michal
Commits
rCOMM49bcd23b617f: [lib] Deprecate `useRoleDeletableAndEditableStatus` and determine `is…
Summary

Context: https://linear.app/comm/issue/ENG-6949/update-roledeletableandeditablestatus-to-use-specialrole-field

We can use specialRole field and roleIsDefaultRole and roleIsAdminRole utilities directly instead of doing this in a separate hook.

Depends on D11206

Test Plan

Make sure that RoleActionsMenu appears and behaves as expected.

Will put screenshots in here shortly:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Mar 1 2024, 12:57 PM
Herald added a subscriber: ashoat. · View Herald TranscriptMar 1 2024, 12:58 PM
Harbormaster completed remote builds in B27257: Diff 37734.Mar 1 2024, 1:13 PM
atul requested review of this revision.Mar 1 2024, 1:13 PM
atul added a child revision: D11209: [lib] Update `threadHasAdminRole` to consider `specialField`.Mar 1 2024, 1:16 PM
tomek accepted this revision.Mar 4 2024, 1:05 AM

We should reintroduce the util (probably as a simple function) if we would need to decide if we can edit / delete a role in some other places.

This revision is now accepted and ready to land.Mar 4 2024, 1:05 AM
atul added a comment.Mar 19 2024, 10:32 AM

This is safe to land because we will fall back to previous roleIsAdminRole and roleIsDefaultRole logic if specialRole field is missing (as it will on web when landed prior to "flipping the switch").

In D11208#324212, @tomek wrote:

We should reintroduce the util (probably as a simple function) if we would need to decide if we can edit / delete a role in some other places.

Yeah, agree but figure this reduces indirection for time being when there's a single instance.

atul updated this revision to Diff 38199.Mar 19 2024, 10:35 AM

rebase around and land

Harbormaster completed remote builds in B27605: Diff 38199.Mar 19 2024, 10:49 AM
Closed by commit rCOMM49bcd23b617f: [lib] Deprecate `useRoleDeletableAndEditableStatus` and determine `is… (authored by atul). · Explain WhyMar 19 2024, 10:51 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM49bcd23b617f: [lib] Deprecate `useRoleDeletableAndEditableStatus` and determine `is….

Revision Contents
Changeset List

PathSize
lib/
utils/
21 lines
web/
roles/
15 lines

Diff 38200

View Options

lib/utils/role-utils.js

Loading...
View Options

web/roles/role-actions-menu.react.js

Loading...