We're updating the specialRole client migrations to include exclusion of isDefault field. This is corresponding keyserver change to match that.
Depends on D11254
Details
Details
Set the includeSpecialRoleFieldInRoles flag manually and observe that isDefault included before and excluded after.
Will attach screenshots.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/shared/thread-utils.js | ||
|---|---|---|
| 904–907 ↗ | (On Diff #37901) | Not sure if it is worth using an util for it - in most of the places we're simply spreading the value |
| lib/shared/thread-utils.js | ||
|---|---|---|
| 904–907 ↗ | (On Diff #37901) | Considered destructuring to exclude isDefault but thought it got a little difficult to read with (([key, {isDefault, ...role}]) => .... Also felt that _omit made it more explicit. |