Details

Reviewers

kamil
tomek

Commits

rCOMM3ddad4e6437a: Introduce EncryptedNotifUtilsAPI and implement it on the keyserver

Summary

This differential introduces EncryptedNotifUtilsAPI. It serves the same purpose as olmAPI or sqliteAPI. During notification generation and encryption we will use the same utilities on all platforms but their implementations will be platform specific. This diff implements it for keyserver only for now. Future diffs will implement it on native and web as well.

Test Plan

Flow
Test all notifs for all platforms and large notifs as well.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Jun 11 2024, 10:36 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJun 11 2024, 10:36 AM

marcin added a parent revision: D12395: Enable encrypted notifications to have keyservevrID or senderDeviceID.Jun 11 2024, 10:36 AM

marcin added a child revision: D12397: Move notification creaction and encryption to lib except for APNs noifs..Jun 11 2024, 10:40 AM

Harbormaster completed remote builds in B29604: Diff 41213.Jun 11 2024, 10:54 AM

marcin requested review of this revision.Jun 11 2024, 10:54 AM

ashoat added inline comments.Jun 12 2024, 8:45 AM

lib/types/notif-types.js
2	Nit: you seem to have accidentally cut a line break here

I would consider registering config for keyserver to be able to use encryptedNotifUtilsAPI directly - passing it as a param trough all these functions makes it messy. In the future, we'll also want sqliteAPI to be implemented on keyserver, but this is something we can discuss in the Linear follow-up task because right now Config type is designed specifically for web & native.

This revision is now accepted and ready to land.Jun 19 2024, 3:15 PM

Rebase

Harbormaster completed remote builds in B29820: Diff 41553.Jun 20 2024, 4:37 AM

Rebase

Harbormaster completed remote builds in B29936: Diff 41713.Jun 26 2024, 10:00 AM

Harbormaster completed remote builds in B29937: Diff 41714.

In D12396#354142, @kamil wrote:

I would consider registering config for keyserver to be able to use encryptedNotifUtilsAPI directly - passing it as a param trough all these functions makes it messy. In the future, we'll also want sqliteAPI to be implemented on keyserver, but this is something we can discuss in the Linear follow-up task because right now Config type is designed specifically for web & native.

Created: https://linear.app/comm/issue/ENG-8681/extend-config-type-so-that-it-can-be-used-on-the-kesyerver to track.