Page MenuHomePhabricator
Differential D12476

Move groupping device by platform details and notif info generation promise to utils in lib/push
AcceptedPublic
Actions

Authored by marcin on Wed, Jun 19, 1:17 PM.
Tags
None
Referenced Files
F2169603: D12476.id41494.diff
Tue, Jul 2, 12:14 PM
F2169560: D12476.id41568.diff
Tue, Jul 2, 12:07 PM
Unknown Object (File)
Sun, Jun 30, 3:21 PM
Unknown Object (File)
Sun, Jun 30, 2:52 AM
Unknown Object (File)
Sun, Jun 30, 12:25 AM
Unknown Object (File)
Thu, Jun 27, 6:00 PM
Unknown Object (File)
Wed, Jun 26, 9:01 AM
Unknown Object (File)
Tue, Jun 25, 6:55 PM
View All 16 Files
Subscribers
ashoat

Details

Reviewers
kamil
tomek
Summary

This differential moves a utility function that groups devices by platform details to lib since we will need it for client-sent notifs as well.

Test Plan

check that notifs work on the keyserver.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Wed, Jun 19, 1:17 PM
Herald added a subscriber: ashoat. · View Herald TranscriptWed, Jun 19, 1:17 PM
marcin added a parent revision: D12464: Implement notification texts generation on the client.Wed, Jun 19, 1:18 PM
marcin added a child revision: D12477: Implement building encrypted notifications on the client.Wed, Jun 19, 1:23 PM
Harbormaster completed remote builds in B29772: Diff 41494.Wed, Jun 19, 1:33 PM
marcin requested review of this revision.Wed, Jun 19, 1:33 PM
marcin updated this revision to Diff 41568.Thu, Jun 20, 4:59 AM

Rebacr

marcin added a comment.Thu, Jun 20, 5:00 AM

This diff is pure copy paste. No additional logic.

Harbormaster completed remote builds in B29833: Diff 41568.Thu, Jun 20, 5:45 AM
kamil accepted this revision.Thu, Jun 27, 5:03 AM
kamil added inline comments.
lib/push/utils.js
2 ↗(On Diff #41568)

add empty line here

5–6 ↗(On Diff #41568)

can be merged

86–94 ↗(On Diff #41568)

can you update this to be an object?

This revision is now accepted and ready to land.Thu, Jun 27, 5:03 AM
ashoat added inline comments.Mon, Jul 1, 12:09 PM
lib/push/utils.js
5–6 ↗(On Diff #41568)

These are actually different files

86–94 ↗(On Diff #41568)

+1, way too many functions with a huge number of parameters in this stack. We should max out around 4 params, unless multiple are booleans in which case it's more like 2-3

Revision Contents
Changeset List

PathSize
keyserver/
src/
creators/
7 lines
push/
73 lines
lib/
push/
80 lines
166 lines

Diff 41494

View Options

keyserver/src/creators/message-creator.js

Loading...
View Options

keyserver/src/push/send.js

Loading...
View Options

lib/push/send-utils.js

Loading...
View Options

lib/push/utils.js

Loading...