[keyserver][lib][native][web] Rename PERSONAL and PRIVATE threadTypes
ClosedPublic
Actions

Authored by ashoat on Jun 19 2024, 5:05 PM.

Details

Reviewers

kamil
marcin

Commits

rCOMMc47d4210be3e: [keyserver][lib][native][web] Rename PERSONAL and PRIVATE threadTypes

Summary

We're going to be replacing these with E2EE DMs. Renaming them now so I can use a new constant with the old names.

Depends on D12481

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jun 19 2024, 5:05 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 19 2024, 5:05 PM

ashoat added a child revision: D12483: [keyserver] Remove threadTypes.LOCAL from newThreadRequestInputValidator.Jun 19 2024, 5:06 PM

Harbormaster completed remote builds in B29786: Diff 41518.Jun 19 2024, 5:22 PM

ashoat requested review of this revision.Jun 19 2024, 5:22 PM

kamil accepted this revision.Jun 20 2024, 2:08 AM

This revision is now accepted and ready to land.Jun 20 2024, 2:08 AM

Closed by commit rCOMMc47d4210be3e: [keyserver][lib][native][web] Rename PERSONAL and PRIVATE threadTypes (authored by ashoat). · Explain WhyJun 26 2024, 11:39 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMc47d4210be3e: [keyserver][lib][native][web] Rename PERSONAL and PRIVATE threadTypes.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

bots/

commbot.js

2 lines

creators/

account-creator.js

2 lines

thread-creator.js

14 lines

database/

migration-config.js

2 lines

fetchers/

thread-fetchers.js

2 lines

responders/

thread-responders.js

2 lines

scripts/

add-leave-thread-permissions.js

2 lines

updaters/

relationship-updaters.js

14 lines

lib/

components/

chat-mention-provider.react.js

4 lines

permissions/

minimally-encoded-thread-permissions-test-data.js

6 lines

special-roles.test.js

2 lines

thread-permissions.js

4 lines

selectors/

user-selectors.js

2 lines

shared/

avatar-utils.js

8 lines

sidebar-utils.js

2 lines

state-sync/

threads-state-sync-spec.test.js

12 lines

thread-utils.js

36 lines

thread-utils.test.js

2 lines

types/

thread-types-enum.js

6 lines

validation.test.js

2 lines

utils/

entity-text.js

2 lines

native/

avatars/

thread-avatar.react.js

4 lines

chat/

chat-thread-list.react.js

2 lines

compose-thread-button.react.js

2 lines

message-list.react.js

2 lines

settings/

thread-settings.react.js

3 lines

components/

thread-icon.react.js

2 lines

redux/

edit-thread-permission-migration.js

4 lines

web/

avatars/

thread-avatar.react.js

4 lines

chat/

chat-message-list.react.js

2 lines

chat-thread-composer.react.js

2 lines

thread-menu.react.js

2 lines

utils/

thread-utils.js

4 lines

Diff 41518

View Options

keyserver/src/bots/commbot.js

View Options

keyserver/src/creators/account-creator.js

View Options

keyserver/src/creators/thread-creator.js

View Options

keyserver/src/database/migration-config.js

View Options

keyserver/src/fetchers/thread-fetchers.js

View Options

keyserver/src/responders/thread-responders.js

View Options

keyserver/src/scripts/add-leave-thread-permissions.js

View Options

keyserver/src/updaters/relationship-updaters.js

View Options

lib/components/chat-mention-provider.react.js

View Options

lib/permissions/minimally-encoded-thread-permissions-test-data.js

View Options

lib/permissions/special-roles.test.js

View Options

lib/permissions/thread-permissions.js

View Options

lib/selectors/user-selectors.js

View Options

lib/shared/avatar-utils.js

View Options

lib/shared/sidebar-utils.js

View Options

lib/shared/state-sync/threads-state-sync-spec.test.js

View Options

lib/shared/thread-utils.js

View Options

lib/shared/thread-utils.test.js

View Options

lib/types/thread-types-enum.js

View Options

lib/types/validation.test.js

View Options

lib/utils/entity-text.js

View Options

native/avatars/thread-avatar.react.js

View Options

native/chat/chat-thread-list.react.js

View Options

native/chat/compose-thread-button.react.js

View Options

native/chat/message-list.react.js

View Options

native/chat/settings/thread-settings.react.js

View Options

native/components/thread-icon.react.js

View Options

native/redux/edit-thread-permission-migration.js

View Options

web/avatars/thread-avatar.react.js

View Options

web/chat/chat-message-list.react.js

View Options

web/chat/chat-thread-composer.react.js

View Options

web/chat/thread-menu.react.js

View Options

[keyserver][lib][native][web] Rename PERSONAL and PRIVATE threadTypesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 41518

keyserver/src/bots/commbot.js

keyserver/src/creators/account-creator.js

keyserver/src/creators/thread-creator.js

keyserver/src/database/migration-config.js

keyserver/src/fetchers/thread-fetchers.js

keyserver/src/responders/thread-responders.js

keyserver/src/scripts/add-leave-thread-permissions.js

keyserver/src/updaters/relationship-updaters.js

lib/components/chat-mention-provider.react.js

lib/permissions/minimally-encoded-thread-permissions-test-data.js

lib/permissions/special-roles.test.js

lib/permissions/thread-permissions.js

lib/selectors/user-selectors.js

lib/shared/avatar-utils.js

lib/shared/sidebar-utils.js

lib/shared/state-sync/threads-state-sync-spec.test.js

lib/shared/thread-utils.js

lib/shared/thread-utils.test.js

lib/types/thread-types-enum.js

lib/types/validation.test.js

lib/utils/entity-text.js

native/avatars/thread-avatar.react.js

native/chat/chat-thread-list.react.js

native/chat/compose-thread-button.react.js

native/chat/message-list.react.js

native/chat/settings/thread-settings.react.js

native/components/thread-icon.react.js

native/redux/edit-thread-permission-migration.js

web/avatars/thread-avatar.react.js

web/chat/chat-message-list.react.js

web/chat/chat-thread-composer.react.js

web/chat/thread-menu.react.js

web/utils/thread-utils.js

[keyserver][lib][native][web] Rename PERSONAL and PRIVATE threadTypes
ClosedPublic
Actions

Revision Contents
Changeset List