Page MenuHomePhabricator
Differential D12489

[keyserver][lib] Update thread type assertion functions for thick/thread distinction
ClosedPublic
Actions

Authored by ashoat on Jun 19 2024, 5:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 3, 10:00 PM
Unknown Object (File)
Mar 5 2025, 6:06 AM
Unknown Object (File)
Feb 21 2025, 3:58 PM
Unknown Object (File)
Feb 1 2025, 5:36 AM
Unknown Object (File)
Feb 1 2025, 5:36 AM
Unknown Object (File)
Feb 1 2025, 5:34 AM
Unknown Object (File)
Jan 31 2025, 7:46 PM
Unknown Object (File)
Jan 23 2025, 5:17 AM
View All 94 Files
Subscribers
tomek

Details

Reviewers
kamil
marcin
Commits
rCOMM468aaa0278a5: [keyserver][lib] Update thread type assertion functions for thick/thread…
Summary

Depends on D12488

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
keyserver/
src/
updaters/
20 lines
lib/
types/
35 lines

Diff 41525

View Options

keyserver/src/updaters/thread-permission-updaters.js

  • This file was added.
#import "CommServicesAuthMetadataEmitter.h"
#import <Foundation/Foundation.h>
#import <React/RCTBridgeModule.h>
#import <React/RCTEventEmitter.h>
NSString *const commServicesAuthMetadata = @"commServicesAuthMetadata";
@interface CommServicesAuthMetadataEmitterIOSWrapper
marcinAuthorUnsubmitted
Done
Inline Actions

It might look uncommon to have interface declaration and implementation next to each other in a single file but in fact we don't need to expose CommServicesAuthMetadataIOSWrapper. If we want to call sendAuthMetadataToJS from Objective - C we can use the common C++ API so let's avoid creating unnecessary files and duplication the same API.

marcin: It might look uncommon to have interface declaration and implementation next to each other in a…
bartekUnsubmitted
Not Done
Inline Actions

It's not that uncommon 😉 I've seen this pattern already in some RN-related code and it makes sense here

bartek: It's not that uncommon 😉 I've seen this pattern already in some RN-related code and it makes…
: RCTEventEmitter <RCTBridgeModule>
@property(nonatomic) BOOL hasListeners;
+ (void)sendToJSAccessToken:(NSString *)accessToken
withUserID:(NSString *)userID
withDeviceID:(NSString *)deviceID;
bartekUnsubmitted
Not Done
Inline Actions

What about sendAccessTokenToJS: ... withUserID: ... withDeviceID?

Initially, I got confused because I understood sendToJSAccessToken as "send something to JS-based access token" 😅

bartek: What about `sendAccessTokenToJS: ... withUserID: ... withDeviceID`? Initially, I got confused…
varunUnsubmitted
Not Done
Inline Actions

+1

varun: +1
@end
@implementation CommServicesAuthMetadataEmitterIOSWrapper
RCT_EXPORT_MODULE(CommServicesAuthMetadataEmitter);
static CommServicesAuthMetadataEmitterIOSWrapper *sharedInstance = nil;
- (instancetype)init {
self = [super init];
if (!self) {
return self;
}
_hasListeners = NO;
return self;
}
- (void)startObserving {
@synchronized([self class]) {
_hasListeners = YES;
sharedInstance = self;
}
}
- (void)stopObserving {
@synchronized([self class]) {
_hasListeners = NO;
sharedInstance = nil;
}
}
- (NSArray<NSString *> *)supportedEvents {
return @[ commServicesAuthMetadata ];
}
- (NSDictionary *)constantsToExport {
return @{@"COMM_SERVICES_AUTH_METADATA" : commServicesAuthMetadata};
}
+ (BOOL)requiresMainQueueSetup {
return YES;
}
+ (void)sendToJSAccessToken:(NSString *)accessToken
withUserID:(NSString *)userID
withDeviceID:(NSString *)deviceID {
@synchronized([self class]) {
if (!sharedInstance) {
return;
}
NSDictionary *eventBody = @{
@"accessToken" : accessToken,
@"userID" : userID,
@"deviceID" : deviceID
};
[sharedInstance sendEventWithName:commServicesAuthMetadata body:eventBody];
}
}
@end
namespace comm {
void CommServicesAuthMetadataEmitter::sendAuthMetadataToJS(
rust::String accessToken,
rust::String userID,
rust::String deviceID) {
NSString *accessTokenObjC =
[NSString stringWithCString:std::string(accessToken).c_str()
encoding:NSUTF8StringEncoding];
NSString *userIDObjC = [NSString stringWithCString:std::string(userID).c_str()
encoding:NSUTF8StringEncoding];
NSString *deviceIDObjC =
[NSString stringWithCString:std::string(deviceID).c_str()
encoding:NSUTF8StringEncoding];
[CommServicesAuthMetadataEmitterIOSWrapper sendToJSAccessToken:accessTokenObjC
withUserID:userIDObjC
withDeviceID:deviceIDObjC];
}
} // namespace comm
View Options

lib/types/thread-types-enum.js

  • This file was added.
#import "CommServicesAuthMetadataEmitter.h"
#import <Foundation/Foundation.h>
#import <React/RCTBridgeModule.h>
#import <React/RCTEventEmitter.h>
NSString *const commServicesAuthMetadata = @"commServicesAuthMetadata";
@interface CommServicesAuthMetadataEmitterIOSWrapper
marcinAuthorUnsubmitted
Done
Inline Actions

It might look uncommon to have interface declaration and implementation next to each other in a single file but in fact we don't need to expose CommServicesAuthMetadataIOSWrapper. If we want to call sendAuthMetadataToJS from Objective - C we can use the common C++ API so let's avoid creating unnecessary files and duplication the same API.

marcin: It might look uncommon to have interface declaration and implementation next to each other in a…
bartekUnsubmitted
Not Done
Inline Actions

It's not that uncommon 😉 I've seen this pattern already in some RN-related code and it makes sense here

bartek: It's not that uncommon 😉 I've seen this pattern already in some RN-related code and it makes…
: RCTEventEmitter <RCTBridgeModule>
@property(nonatomic) BOOL hasListeners;
+ (void)sendToJSAccessToken:(NSString *)accessToken
withUserID:(NSString *)userID
withDeviceID:(NSString *)deviceID;
bartekUnsubmitted
Not Done
Inline Actions

What about sendAccessTokenToJS: ... withUserID: ... withDeviceID?

Initially, I got confused because I understood sendToJSAccessToken as "send something to JS-based access token" 😅

bartek: What about `sendAccessTokenToJS: ... withUserID: ... withDeviceID`? Initially, I got confused…
varunUnsubmitted
Not Done
Inline Actions

+1

varun: +1
@end
@implementation CommServicesAuthMetadataEmitterIOSWrapper
RCT_EXPORT_MODULE(CommServicesAuthMetadataEmitter);
static CommServicesAuthMetadataEmitterIOSWrapper *sharedInstance = nil;
- (instancetype)init {
self = [super init];
if (!self) {
return self;
}
_hasListeners = NO;
return self;
}
- (void)startObserving {
@synchronized([self class]) {
_hasListeners = YES;
sharedInstance = self;
}
}
- (void)stopObserving {
@synchronized([self class]) {
_hasListeners = NO;
sharedInstance = nil;
}
}
- (NSArray<NSString *> *)supportedEvents {
return @[ commServicesAuthMetadata ];
}
- (NSDictionary *)constantsToExport {
return @{@"COMM_SERVICES_AUTH_METADATA" : commServicesAuthMetadata};
}
+ (BOOL)requiresMainQueueSetup {
return YES;
}
+ (void)sendToJSAccessToken:(NSString *)accessToken
withUserID:(NSString *)userID
withDeviceID:(NSString *)deviceID {
@synchronized([self class]) {
if (!sharedInstance) {
return;
}
NSDictionary *eventBody = @{
@"accessToken" : accessToken,
@"userID" : userID,
@"deviceID" : deviceID
};
[sharedInstance sendEventWithName:commServicesAuthMetadata body:eventBody];
}
}
@end
namespace comm {
void CommServicesAuthMetadataEmitter::sendAuthMetadataToJS(
rust::String accessToken,
rust::String userID,
rust::String deviceID) {
NSString *accessTokenObjC =
[NSString stringWithCString:std::string(accessToken).c_str()
encoding:NSUTF8StringEncoding];
NSString *userIDObjC = [NSString stringWithCString:std::string(userID).c_str()
encoding:NSUTF8StringEncoding];
NSString *deviceIDObjC =
[NSString stringWithCString:std::string(deviceID).c_str()
encoding:NSUTF8StringEncoding];
[CommServicesAuthMetadataEmitterIOSWrapper sendToJSAccessToken:accessTokenObjC
withUserID:userIDObjC
withDeviceID:deviceIDObjC];
}
} // namespace comm