Page MenuHomePhabricator
Differential D12556

[lib] Remove `threadOrParentThreadHasAdminRole` and `memberHadAdminPowers`
AbandonedPublic
Actions

Authored by atul on Jun 24 2024, 10:42 AM.
Tags
None
Referenced Files
F3280683: D12556.id41661.diff
Sat, Nov 16, 9:17 AM
F3280029: D12556.diff
Sat, Nov 16, 8:58 AM
Unknown Object (File)
Sun, Nov 10, 4:22 PM
Unknown Object (File)
Sat, Nov 2, 4:09 PM
Unknown Object (File)
Sat, Nov 2, 4:09 PM
Unknown Object (File)
Sat, Nov 2, 3:56 PM
Unknown Object (File)
Wed, Oct 23, 7:22 PM
Unknown Object (File)
Wed, Oct 23, 7:21 PM
View All 34 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
varun
Summary

Neither of these are used anymore after D12554 and D12543

Depends on D12554

Test Plan

flow + searching codebase for references.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jun 24 2024, 10:42 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 24 2024, 10:55 AM
Harbormaster failed remote builds in B29902: Diff 41661!
atul added a child revision: D12557: [lib] Change return type of `minimallyEncodeRawThreadInfo` to `RawThreadInfoWithMemberPermissions`.Jun 24 2024, 3:31 PM
atul requested review of this revision.Jun 25 2024, 9:41 AM
atul removed a child revision: D12557: [lib] Change return type of `minimallyEncodeRawThreadInfo` to `RawThreadInfoWithMemberPermissions`.Jun 26 2024, 1:48 PM
atul abandoned this revision.Jun 27 2024, 12:04 PM

Abandoning because changes are now included in D12554

(Being outside of stack with flow issues ignored via --no-verify revealed some ESLint things)

Revision Contents
Changeset List

PathSize
lib/
shared/
22 lines

Diff 41661

View Options

lib/shared/thread-utils.js

Loading...