Paths

Table of Contentst

Differential D12554

[lib] Remove `threadFrozenDueToBlock`, `threadOrParentThreadHasAdminRole` and `memberHadAdminPowers`
ClosedPublic
Actions

Authored by atul on Jun 24 2024, 10:40 AM.

Tags

None

Referenced Files

	F3280967: D12554.id41659.diff
	Sat, Nov 16, 9:25 AM

	F3280896: D12554.id41764.diff
	Sat, Nov 16, 9:24 AM

	Unknown Object (File)
	Fri, Nov 1, 9:30 PM

	Unknown Object (File)
	Wed, Oct 23, 7:22 PM

	Unknown Object (File)
	Wed, Oct 23, 7:22 PM

	Unknown Object (File)
	Wed, Oct 23, 7:22 PM

	Unknown Object (File)
	Wed, Oct 23, 7:21 PM

	Unknown Object (File)
	Mon, Oct 21, 3:29 AM

View All 79 Files

Subscribers

None

Details

Reviewers

Commits

rCOMMe5ebff3685d6: [lib] Remove `threadFrozenDueToBlock`, `threadOrParentThreadHasAdminRole` and…

Summary

Last usage was removed in D12543, also removed functions where only usage was via threadFrozenDueToBlock

Depends on D12543

Test Plan

flow + searching codebase to make sure there are no remaining references.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jun 24 2024, 10:40 AM

atul added a child revision: D12556: [lib] Remove `threadOrParentThreadHasAdminRole` and `memberHadAdminPowers`.Jun 24 2024, 10:42 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 24 2024, 10:53 AM

Harbormaster failed remote builds in B29900: Diff 41659!

atul requested review of this revision.Jun 25 2024, 9:41 AM

rebase outside of flow stack

Harbormaster failed remote builds in B29942: Diff 41736!Jun 26 2024, 1:52 PM

amend

atul retitled this revision from [lib] Remove `threadFrozenDueToBlock` to [lib] Remove `threadFrozenDueToBlock`, `threadOrParentThreadHasAdminRole` and `memberHadAdminPowers`.Jun 27 2024, 12:03 PM

atul mentioned this in D12556: [lib] Remove `threadOrParentThreadHasAdminRole` and `memberHadAdminPowers`.

Harbormaster completed remote builds in B29965: Diff 41764.Jun 27 2024, 12:18 PM

atul added a child revision: D12594: [lib] Change type of `ThinRawThreadInfo.members` from `MemberInfoWithPermissions` to `MemberInfoSansPermissions`.Jun 27 2024, 12:31 PM

atul removed reviewers: ginsu, tomek, varun.Jun 27 2024, 1:44 PM

Woooo!!! Sorry this took so long to review.

This revision is now accepted and ready to land.Jul 1 2024, 12:34 PM

rebase and land

This revision was landed with ongoing or failed builds.Jul 9 2024, 10:22 AM

Closed by commit rCOMMe5ebff3685d6: [lib] Remove `threadFrozenDueToBlock`, `threadOrParentThreadHasAdminRole` and… (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMe5ebff3685d6: [lib] Remove `threadFrozenDueToBlock`, `threadOrParentThreadHasAdminRole` and….

Harbormaster completed remote builds in B30228: Diff 42150.Jul 9 2024, 10:42 AM

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

29 lines

Diff 41736

lib/shared/thread-utils.js

Loading...