Page MenuHomePhabricator
Differential D12554

[lib] Remove `threadFrozenDueToBlock`, `threadOrParentThreadHasAdminRole` and `memberHadAdminPowers`
ClosedPublic
Actions

Authored by atul on Jun 24 2024, 10:40 AM.
Tags
None
Referenced Files
F3373933: D12554.diff
Tue, Nov 26, 12:43 PM
Unknown Object (File)
Sat, Nov 23, 3:17 AM
Unknown Object (File)
Thu, Nov 21, 12:17 AM
Unknown Object (File)
Wed, Nov 20, 10:16 PM
Unknown Object (File)
Wed, Nov 20, 10:16 PM
Unknown Object (File)
Wed, Nov 20, 5:32 PM
Unknown Object (File)
Sat, Nov 16, 11:46 AM
Unknown Object (File)
Sat, Nov 16, 9:25 AM
View All 86 Files
Subscribers
None

Details

Reviewers
ashoat
Commits
rCOMMe5ebff3685d6: [lib] Remove `threadFrozenDueToBlock`, `threadOrParentThreadHasAdminRole` and…
Summary

Last usage was removed in D12543, also removed functions where only usage was via threadFrozenDueToBlock

Depends on D12543

Test Plan

flow + searching codebase to make sure there are no remaining references.

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D12554 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jun 24 2024, 10:40 AM
atul added a child revision: D12556: [lib] Remove `threadOrParentThreadHasAdminRole` and `memberHadAdminPowers`.Jun 24 2024, 10:42 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 24 2024, 10:53 AM
Harbormaster failed remote builds in B29900: Diff 41659!
atul requested review of this revision.Jun 25 2024, 9:41 AM
atul updated this revision to Diff 41736.Jun 26 2024, 1:40 PM

rebase outside of flow stack

Harbormaster failed remote builds in B29942: Diff 41736!Jun 26 2024, 1:52 PM
atul updated this revision to Diff 41764.Jun 27 2024, 12:02 PM

amend

atul retitled this revision from [lib] Remove `threadFrozenDueToBlock` to [lib] Remove `threadFrozenDueToBlock`, `threadOrParentThreadHasAdminRole` and `memberHadAdminPowers`.Jun 27 2024, 12:03 PM
atul mentioned this in D12556: [lib] Remove `threadOrParentThreadHasAdminRole` and `memberHadAdminPowers`.
Harbormaster completed remote builds in B29965: Diff 41764.Jun 27 2024, 12:18 PM
atul added a child revision: D12594: [lib] Change type of `ThinRawThreadInfo.members` from `MemberInfoWithPermissions` to `MemberInfoSansPermissions`.Jun 27 2024, 12:31 PM
atul removed reviewers: ginsu, tomek, varun.Jun 27 2024, 1:44 PM
ashoat accepted this revision.Jul 1 2024, 12:34 PM

Woooo!!! Sorry this took so long to review.

This revision is now accepted and ready to land.Jul 1 2024, 12:34 PM
atul updated this revision to Diff 42150.Jul 9 2024, 10:11 AM

rebase and land

This revision was landed with ongoing or failed builds.Jul 9 2024, 10:22 AM
Closed by commit rCOMMe5ebff3685d6: [lib] Remove `threadFrozenDueToBlock`, `threadOrParentThreadHasAdminRole` and… (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMe5ebff3685d6: [lib] Remove `threadFrozenDueToBlock`, `threadOrParentThreadHasAdminRole` and….
Harbormaster completed remote builds in B30228: Diff 42150.Jul 9 2024, 10:42 AM

Revision Contents
Changeset List

PathSize
lib/
shared/
53 lines

Diff 42150

View Options

lib/shared/thread-utils.js

Loading...