Our EnumSettingsOption component on native only supports checkbox type input. For this new thread notif settings experience we need to have a radio type input
Depends on D12642
Details
Details
Confirmed that there were no regressions with where we render EnumSettingsOption in the create roles and community creation screens
Also confirmed that the radio input looked like this:
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
- Can we try to space it out more? I'd like more margin between option, and to balance the space on the right side. We can try to work through it together tomorrow in person if you're in the office
- If 2/3 of the usages are going to checkbox instead of radio, should we default to checkbox?
Comment Actions
Can we try to space it out more? I'd like more margin between option, and to balance the space on the right side. We can try to work through it together tomorrow in person if you're in the office
D12654 updates the UI further in this stack
If 2/3 of the usages are going to checkbox instead of radio, should we default to checkbox?
I did this to match how EnumSettingsOption on web
https://github.com/CommE2E/comm/blob/master/web/components/enum-settings-option.react.js#L43