Page MenuHomePhabricator
Differential D12947

[native] Rename Nux Tips Overlay (and simplify types)
ClosedPublic
Actions

Authored by inka on Jul 30 2024, 7:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 6, 8:58 AM
Unknown Object (File)
Mon, Mar 24, 3:00 PM
Unknown Object (File)
Mar 12 2025, 8:56 PM
Unknown Object (File)
Mar 7 2025, 2:25 AM
Unknown Object (File)
Mar 6 2025, 2:56 PM
Unknown Object (File)
Mar 6 2025, 10:07 AM
Unknown Object (File)
Mar 5 2025, 2:41 PM
Unknown Object (File)
Mar 4 2025, 9:50 AM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
will
Commits
rCOMMc14514c35977: [native] Rename Nux Tips Overlay (and simplify types)
Summary

issue: ENG-8534

Test Plan

Tested by creating a component with createNuxTipsOverlay and navigating to it. It appears correctly.

Diff Detail

Repository
rCOMM Comm
Branch
inka/nux
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Jul 30 2024, 7:01 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJul 30 2024, 7:01 AM
inka added a parent revision: D12942: [native] Remove irrelevant code from nux tips overlay.Jul 30 2024, 7:01 AM
Harbormaster completed remote builds in B30817: Diff 42970.Jul 30 2024, 7:23 AM
inka requested review of this revision.Jul 30 2024, 7:23 AM
tomek accepted this revision.Jul 31 2024, 6:16 AM
tomek added inline comments.
native/navigation/route-names.js
170 ↗(On Diff #42970)

NUX is an acronym and should be capitalized.

This revision is now accepted and ready to land.Jul 31 2024, 6:16 AM
inka updated this revision to Diff 42994.Jul 31 2024, 6:38 AM

Capitalize

Harbormaster failed remote builds in B30836: Diff 42994!Jul 31 2024, 6:50 AM
inka added a child revision: D12963: [native] Add nux context.Aug 5 2024, 1:38 AM
inka updated this revision to Diff 43099.Aug 5 2024, 5:49 AM
inka marked an inline comment as done.

Fix file import

Harbormaster completed remote builds in B30919: Diff 43099.Aug 5 2024, 7:21 AM
Closed by commit rCOMMc14514c35977: [native] Rename Nux Tips Overlay (and simplify types) (authored by inka). · Explain WhyAug 13 2024, 5:43 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMMc14514c35977: [native] Rename Nux Tips Overlay (and simplify types).

Revision Contents
Changeset List

PathSize
native/
navigation/
3 lines
tooltip/
131 lines

Diff 42994

View Options

native/navigation/route-names.js

Show All 12 Lines
use lazy_static::lazy_static; use lazy_static::lazy_static;
use serde::Serialize; use serde::Serialize;
use std::sync::Arc; use std::sync::Arc;
use tokio::runtime::{Builder, Runtime}; use tokio::runtime::{Builder, Runtime};
use tonic::Status; use tonic::Status;
use tracing::instrument; use tracing::instrument;
mod argon2_tools; mod argon2_tools;
mod backup;
mod constants; mod constants;
use argon2_tools::compute_backup_key_str; use argon2_tools::compute_backup_key_str;
mod generated { mod generated {
// We get the CODE_VERSION from this generated file // We get the CODE_VERSION from this generated file
include!(concat!(env!("OUT_DIR"), "/version.rs")); include!(concat!(env!("OUT_DIR"), "/version.rs"));
} }
Show All 11 Lines Builder::new_multi_thread()
.worker_threads(1) .worker_threads(1)
.max_blocking_threads(1) .max_blocking_threads(1)
.enable_all() .enable_all()
.build() .build()
.unwrap() .unwrap()
); );
} }
use backup::ffi::*;
#[cxx::bridge] #[cxx::bridge]
mod ffi { mod ffi {
extern "Rust" { extern "Rust" {
#[cxx_name = "identityRegisterUser"] #[cxx_name = "identityRegisterUser"]
fn register_user( fn register_user(
username: String, username: String,
password: String, password: String,
▲ Show 20 Lines • Show All 117 Lines • ▼ Show 20 Lines unsafe extern "C++" {
#[allow(unused)] #[allow(unused)]
#[cxx_name = "aesDecrypt"] #[cxx_name = "aesDecrypt"]
fn decrypt( fn decrypt(
key: &mut [u8], key: &mut [u8],
sealed_data: &mut [u8], sealed_data: &mut [u8],
plaintext: &mut [u8], plaintext: &mut [u8],
) -> Result<()>; ) -> Result<()>;
} }
// Backup
extern "Rust" {
#[cxx_name = "createBackup"]
fn create_backup_sync(
backup_id: String,
backup_secret: String,
pickle_key: String,
pickled_account: String,
user_data: String,
promise_id: u32,
);
#[cxx_name = "restoreBackup"]
fn restore_backup_sync(
backup_id: String,
backup_secret: String,
encrypted_user_keys: String,
encrypted_user_data: String,
promise_id: u32,
);
}
} }
fn handle_string_result_as_callback<E>( fn handle_string_result_as_callback<E>(
result: Result<String, E>, result: Result<String, E>,
promise_id: u32, promise_id: u32,
) where ) where
E: std::fmt::Display, E: std::fmt::Display,
{ {
▲ Show 20 Lines • Show All 634 Lines • Show Last 20 Lines
View Options

native/tooltip/nux-tips-overlay.react.js

Show All 12 Lines
use lazy_static::lazy_static; use lazy_static::lazy_static;
use serde::Serialize; use serde::Serialize;
use std::sync::Arc; use std::sync::Arc;
use tokio::runtime::{Builder, Runtime}; use tokio::runtime::{Builder, Runtime};
use tonic::Status; use tonic::Status;
use tracing::instrument; use tracing::instrument;
mod argon2_tools; mod argon2_tools;
mod backup;
mod constants; mod constants;
use argon2_tools::compute_backup_key_str; use argon2_tools::compute_backup_key_str;
mod generated { mod generated {
// We get the CODE_VERSION from this generated file // We get the CODE_VERSION from this generated file
include!(concat!(env!("OUT_DIR"), "/version.rs")); include!(concat!(env!("OUT_DIR"), "/version.rs"));
} }
Show All 11 Lines Builder::new_multi_thread()
.worker_threads(1) .worker_threads(1)
.max_blocking_threads(1) .max_blocking_threads(1)
.enable_all() .enable_all()
.build() .build()
.unwrap() .unwrap()
); );
} }
use backup::ffi::*;
#[cxx::bridge] #[cxx::bridge]
mod ffi { mod ffi {
extern "Rust" { extern "Rust" {
#[cxx_name = "identityRegisterUser"] #[cxx_name = "identityRegisterUser"]
fn register_user( fn register_user(
username: String, username: String,
password: String, password: String,
▲ Show 20 Lines • Show All 117 Lines • ▼ Show 20 Lines unsafe extern "C++" {
#[allow(unused)] #[allow(unused)]
#[cxx_name = "aesDecrypt"] #[cxx_name = "aesDecrypt"]
fn decrypt( fn decrypt(
key: &mut [u8], key: &mut [u8],
sealed_data: &mut [u8], sealed_data: &mut [u8],
plaintext: &mut [u8], plaintext: &mut [u8],
) -> Result<()>; ) -> Result<()>;
} }
// Backup
extern "Rust" {
#[cxx_name = "createBackup"]
fn create_backup_sync(
backup_id: String,
backup_secret: String,
pickle_key: String,
pickled_account: String,
user_data: String,
promise_id: u32,
);
#[cxx_name = "restoreBackup"]
fn restore_backup_sync(
backup_id: String,
backup_secret: String,
encrypted_user_keys: String,
encrypted_user_data: String,
promise_id: u32,
);
}
} }
fn handle_string_result_as_callback<E>( fn handle_string_result_as_callback<E>(
result: Result<String, E>, result: Result<String, E>,
promise_id: u32, promise_id: u32,
) where ) where
E: std::fmt::Display, E: std::fmt::Display,
{ {
▲ Show 20 Lines • Show All 634 Lines • Show Last 20 Lines