Page MenuHomePhabricator
Differential D13329

[web][native] update `InputStateContainer` logic for sending text messages
ClosedPublic
Actions

Authored by kamil on Sep 13 2024, 4:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 5, 12:54 AM
Unknown Object (File)
Sat, Mar 1, 10:58 AM
Unknown Object (File)
Wed, Feb 26, 11:35 AM
Unknown Object (File)
Sat, Feb 15, 9:29 PM
Unknown Object (File)
Sat, Feb 15, 9:29 PM
Unknown Object (File)
Feb 3 2025, 12:34 PM
Unknown Object (File)
Feb 1 2025, 12:22 AM
Unknown Object (File)
Jan 31 2025, 4:00 PM
View All 72 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMM303c9c123089: [web][native] update `InputStateContainer` logic for sending text messages
Summary

ENG-8424.

This makes updates code to use one hook on both platforms which handles both thick and thin threads, and avoids hacking logic on both InputStateContainer implementations.

Depends on D13328

Test Plan

Tested end-to-end according to the process described here.

Additionally, tested creating threads and sidebars.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Sep 13 2024, 4:12 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptSep 13 2024, 4:12 AM
Harbormaster failed remote builds in B31598: Diff 44143!Sep 13 2024, 4:16 AM
kamil added a child revision: D13330: [web][native][lib] deprecate `sendDMActionTypes` and simplify hooks.Sep 13 2024, 4:17 AM
kamil edited the test plan for this revision. (Show Details)Sep 13 2024, 4:22 AM
Harbormaster completed remote builds in B31598: Diff 44143.Sep 13 2024, 4:37 AM
kamil published this revision for review.Sep 13 2024, 4:40 AM
kamil edited the summary of this revision. (Show Details)
tomek accepted this revision.Sep 13 2024, 6:57 AM
This revision is now accepted and ready to land.Sep 13 2024, 6:57 AM
kamil updated this revision to Diff 44210.Sep 16 2024, 3:08 AM

rebase

Harbormaster completed remote builds in B31638: Diff 44210.Sep 16 2024, 3:28 AM
Closed by commit rCOMM303c9c123089: [web][native] update `InputStateContainer` logic for sending text messages (authored by kamil). · Explain WhySep 16 2024, 4:05 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM303c9c123089: [web][native] update `InputStateContainer` logic for sending text messages.
kamil mentioned this in D13334: Call textMessageCreationSideEffectsFunc after sending DM text message.Sep 17 2024, 12:50 AM

Revision Contents
Changeset List

PathSize
native/
input/
131 lines
web/
input/
132 lines

Diff 44210

View Options

native/input/input-state-container.react.js

Show First 20 Lines • Show All 367 Lines • ▼ Show 20 Lines) {
return threadMembersWithoutAddedAdmin(threadInfo).length > 2; return threadMembersWithoutAddedAdmin(threadInfo).length > 2;
} }
function threadIsPending(threadID: ?string): boolean { function threadIsPending(threadID: ?string): boolean {
return !!threadID?.startsWith('pending'); return !!threadID?.startsWith('pending');
} }
function threadIsPendingSidebar(threadID: ?string): boolean { function threadIsPendingSidebar(threadID: ?string): boolean {
return !!threadID?.startsWith('pending/sidebar/'); return (
!!threadID?.startsWith('pending/sidebar/') ||
!!threadID?.startsWith('pending/dm_sidebar')
tomekUnsubmitted
Not Done
Inline Actions

Can we extract sidebar and dm_sidebar somewhere as constants?

tomek: Can we extract `sidebar` and `dm_sidebar` somewhere as constants?
);
} }
function getSingleOtherUser( function getSingleOtherUser(
threadInfo: LegacyRawThreadInfo | RawThreadInfo | ThreadInfo, threadInfo: LegacyRawThreadInfo | RawThreadInfo | ThreadInfo,
viewerID: ?string, viewerID: ?string,
): ?string { ): ?string {
if (!viewerID) { if (!viewerID) {
return undefined; return undefined;
▲ Show 20 Lines • Show All 1,407 Lines • Show Last 20 Lines
View Options

web/input/input-state-container.react.js

Show First 20 Lines • Show All 367 Lines • ▼ Show 20 Lines) {
return threadMembersWithoutAddedAdmin(threadInfo).length > 2; return threadMembersWithoutAddedAdmin(threadInfo).length > 2;
} }
function threadIsPending(threadID: ?string): boolean { function threadIsPending(threadID: ?string): boolean {
return !!threadID?.startsWith('pending'); return !!threadID?.startsWith('pending');
} }
function threadIsPendingSidebar(threadID: ?string): boolean { function threadIsPendingSidebar(threadID: ?string): boolean {
return !!threadID?.startsWith('pending/sidebar/'); return (
!!threadID?.startsWith('pending/sidebar/') ||
!!threadID?.startsWith('pending/dm_sidebar')
tomekUnsubmitted
Not Done
Inline Actions

Can we extract sidebar and dm_sidebar somewhere as constants?

tomek: Can we extract `sidebar` and `dm_sidebar` somewhere as constants?
);
} }
function getSingleOtherUser( function getSingleOtherUser(
threadInfo: LegacyRawThreadInfo | RawThreadInfo | ThreadInfo, threadInfo: LegacyRawThreadInfo | RawThreadInfo | ThreadInfo,
viewerID: ?string, viewerID: ?string,
): ?string { ): ?string {
if (!viewerID) { if (!viewerID) {
return undefined; return undefined;
▲ Show 20 Lines • Show All 1,407 Lines • Show Last 20 Lines